From: Peter Zijlstra <peterz@infradead.org>
To: Mike Travis <mike.travis@hpe.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bin Gao <bin.gao@linux.intel.com>,
Prarit Bhargava <prarit@redhat.com>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Andrew Banman <andrew.banman@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kevin.b.stanton@intel.com
Subject: Re: [PATCH 0/4] x86/platform/UV: Update TSC support
Date: Fri, 29 Sep 2017 20:41:04 +0200 [thread overview]
Message-ID: <20170929184104.GX6524@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <bedd5a84-34d9-a13b-4b0d-7188d6f8629f@hpe.com>
On Fri, Sep 29, 2017 at 10:39:28AM -0700, Mike Travis wrote:
> >That's where it comes from. But normal systems really _should_ have it
> >at 0 and its a useful sanity check IMO. We really want to know when the
> >BIOS does a funny behind our backs.
> >
>
> How about a more generic flag, such as "multi_tsc_sync_sources"? That could
> trigger both disabling the "TSC == 0 on socket 0" check as well as disabling
> X86_FEATURE_ART where appropriate? Or I could clear the feature ART cap
> separately in the UV system init code if they are not really related?
I _think_ the X86_FEATURE_ART is an artificial flag. We key off of
cpuid_level here.
So that multi_tsc_sync_sources or a more explicit is_uv_system() would
be required.
prev parent reply other threads:[~2017-09-29 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 18:03 mike.travis
2017-09-28 18:03 ` [PATCH 1/4] x86/kernel: Remove requirement that TSC ADJUST must be 0 on socket 0 mike.travis
2017-09-28 18:03 ` [PATCH 2/4] x86/kernel: Skip TSC test and error messages if already unstable mike.travis
2017-09-28 18:03 ` [PATCH 3/4] x86/kernel: Drastically reduce the number of firmware bug warnings mike.travis
2017-09-28 18:03 ` [PATCH 4/4] x86/platform/UV: Add check of TSC state set by UV BIOS mike.travis
2017-09-29 8:46 ` [PATCH 0/4] x86/platform/UV: Update TSC support Peter Zijlstra
2017-09-29 15:19 ` Mike Travis
2017-09-29 16:23 ` Peter Zijlstra
2017-09-29 17:39 ` Mike Travis
2017-09-29 18:41 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929184104.GX6524@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andrew.banman@hpe.com \
--cc=bin.gao@linux.intel.com \
--cc=dimitri.sivanich@hpe.com \
--cc=hpa@zytor.com \
--cc=kevin.b.stanton@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=russ.anderson@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome