From: Sebastian Reichel <sre@kernel.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines
Date: Sun, 1 Oct 2017 17:13:16 +0200 [thread overview]
Message-ID: <20171001151316.mklrwif4tg5nx5ok@earth> (raw)
In-Reply-To: <74daad7cb1d5507d4531b5ac82d5002834156ced.1506406503.git.arvind.yadav.cs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
Hi,
On Tue, Sep 26, 2017 at 11:46:14AM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, queued.
-- Sebastian
> ---
> drivers/hsi/clients/hsi_char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> index 57f70c2..cf9c2a3 100644
> --- a/drivers/hsi/clients/hsi_char.c
> +++ b/drivers/hsi/clients/hsi_char.c
> @@ -773,13 +773,13 @@ static int __init hsc_init(void)
>
> if ((max_data_size < 4) || (max_data_size > 0x10000) ||
> (max_data_size & (max_data_size - 1))) {
> - pr_err("Invalid max read/write data size");
> + pr_err("Invalid max read/write data size\n");
> return -EINVAL;
> }
>
> ret = hsi_register_client_driver(&hsc_driver);
> if (ret) {
> - pr_err("Error while registering HSI/SSI driver %d", ret);
> + pr_err("Error while registering HSI/SSI driver %d\n", ret);
> return ret;
> }
>
> --
> 1.9.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-01 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 6:16 Arvind Yadav
2017-10-01 15:13 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171001151316.mklrwif4tg5nx5ok@earth \
--to=sre@kernel.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®