* [PATCH] HSI: hsi_char: pr_err() strings should end with newlines
@ 2017-09-26 6:16 Arvind Yadav
2017-10-01 15:13 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-09-26 6:16 UTC (permalink / raw)
To: sre; +Cc: linux-kernel
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hsi/clients/hsi_char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
index 57f70c2..cf9c2a3 100644
--- a/drivers/hsi/clients/hsi_char.c
+++ b/drivers/hsi/clients/hsi_char.c
@@ -773,13 +773,13 @@ static int __init hsc_init(void)
if ((max_data_size < 4) || (max_data_size > 0x10000) ||
(max_data_size & (max_data_size - 1))) {
- pr_err("Invalid max read/write data size");
+ pr_err("Invalid max read/write data size\n");
return -EINVAL;
}
ret = hsi_register_client_driver(&hsc_driver);
if (ret) {
- pr_err("Error while registering HSI/SSI driver %d", ret);
+ pr_err("Error while registering HSI/SSI driver %d\n", ret);
return ret;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines
2017-09-26 6:16 [PATCH] HSI: hsi_char: pr_err() strings should end with newlines Arvind Yadav
@ 2017-10-01 15:13 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2017-10-01 15:13 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
Hi,
On Tue, Sep 26, 2017 at 11:46:14AM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, queued.
-- Sebastian
> ---
> drivers/hsi/clients/hsi_char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> index 57f70c2..cf9c2a3 100644
> --- a/drivers/hsi/clients/hsi_char.c
> +++ b/drivers/hsi/clients/hsi_char.c
> @@ -773,13 +773,13 @@ static int __init hsc_init(void)
>
> if ((max_data_size < 4) || (max_data_size > 0x10000) ||
> (max_data_size & (max_data_size - 1))) {
> - pr_err("Invalid max read/write data size");
> + pr_err("Invalid max read/write data size\n");
> return -EINVAL;
> }
>
> ret = hsi_register_client_driver(&hsc_driver);
> if (ret) {
> - pr_err("Error while registering HSI/SSI driver %d", ret);
> + pr_err("Error while registering HSI/SSI driver %d\n", ret);
> return ret;
> }
>
> --
> 1.9.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-01 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-26 6:16 [PATCH] HSI: hsi_char: pr_err() strings should end with newlines Arvind Yadav
2017-10-01 15:13 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®