From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Subject: [PATCH review for 4.9 11/50] staging: rtl8712u: Fix endian settings for structs describing network packets
Date: Sat, 7 Oct 2017 22:36:48 +0000 [thread overview]
Message-ID: <20171007223636.24797-11-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171007223636.24797-1-alexander.levin@verizon.com>
From: Larry Finger <Larry.Finger@lwfinger.net>
[ Upstream commit 221c46d28957bd6e2158abc2179ce4a8c9ce07d3 ]
The headers describing a number of network packets do not have the
correct endian settings for several types of data.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
drivers/staging/rtl8712/ieee80211.h | 84 ++++++++++++++++++-------------------
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h b/drivers/staging/rtl8712/ieee80211.h
index 67ab58084e8a..68fd65e80906 100644
--- a/drivers/staging/rtl8712/ieee80211.h
+++ b/drivers/staging/rtl8712/ieee80211.h
@@ -138,51 +138,51 @@ struct ieee_ibss_seq {
};
struct ieee80211_hdr {
- u16 frame_ctl;
- u16 duration_id;
+ __le16 frame_ctl;
+ __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
- u16 seq_ctl;
+ __le16 seq_ctl;
u8 addr4[ETH_ALEN];
-} __packed;
+} __packed __aligned(2);
struct ieee80211_hdr_3addr {
- u16 frame_ctl;
- u16 duration_id;
+ __le16 frame_ctl;
+ __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
- u16 seq_ctl;
-} __packed;
+ __le16 seq_ctl;
+} __packed __aligned(2);
struct ieee80211_hdr_qos {
- u16 frame_ctl;
- u16 duration_id;
+ __le16 frame_ctl;
+ __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
- u16 seq_ctl;
+ __le16 seq_ctl;
u8 addr4[ETH_ALEN];
- u16 qc;
-} __packed;
+ __le16 qc;
+} __packed __aligned(2);
struct ieee80211_hdr_3addr_qos {
- u16 frame_ctl;
- u16 duration_id;
+ __le16 frame_ctl;
+ __le16 duration_id;
u8 addr1[ETH_ALEN];
u8 addr2[ETH_ALEN];
u8 addr3[ETH_ALEN];
- u16 seq_ctl;
- u16 qc;
+ __le16 seq_ctl;
+ __le16 qc;
} __packed;
struct eapol {
u8 snap[6];
- u16 ethertype;
+ __be16 ethertype;
u8 version;
u8 type;
- u16 length;
+ __le16 length;
} __packed;
enum eap_type {
@@ -514,13 +514,13 @@ struct ieee80211_security {
*/
struct ieee80211_header_data {
- u16 frame_ctl;
- u16 duration_id;
+ __le16 frame_ctl;
+ __le16 duration_id;
u8 addr1[6];
u8 addr2[6];
u8 addr3[6];
- u16 seq_ctrl;
-};
+ __le16 seq_ctrl;
+} __packed __aligned(2);
#define BEACON_PROBE_SSID_ID_POSITION 12
@@ -552,18 +552,18 @@ struct ieee80211_info_element {
/*
* These are the data types that can make up management packets
*
- u16 auth_algorithm;
- u16 auth_sequence;
- u16 beacon_interval;
- u16 capability;
+ __le16 auth_algorithm;
+ __le16 auth_sequence;
+ __le16 beacon_interval;
+ __le16 capability;
u8 current_ap[ETH_ALEN];
- u16 listen_interval;
+ __le16 listen_interval;
struct {
u16 association_id:14, reserved:2;
} __packed;
- u32 time_stamp[2];
- u16 reason;
- u16 status;
+ __le32 time_stamp[2];
+ __le16 reason;
+ __le16 status;
*/
#define IEEE80211_DEFAULT_TX_ESSID "Penguin"
@@ -571,16 +571,16 @@ struct ieee80211_info_element {
struct ieee80211_authentication {
struct ieee80211_header_data header;
- u16 algorithm;
- u16 transaction;
- u16 status;
+ __le16 algorithm;
+ __le16 transaction;
+ __le16 status;
} __packed;
struct ieee80211_probe_response {
struct ieee80211_header_data header;
- u32 time_stamp[2];
- u16 beacon_interval;
- u16 capability;
+ __le32 time_stamp[2];
+ __le16 beacon_interval;
+ __le16 capability;
struct ieee80211_info_element info_element;
} __packed;
@@ -590,16 +590,16 @@ struct ieee80211_probe_request {
struct ieee80211_assoc_request_frame {
struct ieee80211_hdr_3addr header;
- u16 capability;
- u16 listen_interval;
+ __le16 capability;
+ __le16 listen_interval;
struct ieee80211_info_element_hdr info_element;
} __packed;
struct ieee80211_assoc_response_frame {
struct ieee80211_hdr_3addr header;
- u16 capability;
- u16 status;
- u16 aid;
+ __le16 capability;
+ __le16 status;
+ __le16 aid;
} __packed;
struct ieee80211_txb {
--
2.11.0
next prev parent reply other threads:[~2017-10-07 22:50 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 22:36 [PATCH review for 4.9 01/50] cpufreq: Do not clear real_cpus mask on policy init Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 03/50] staging: fsl-mc: Add missing header Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 02/50] crypto: ccp - Set the AES size field for all modes Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 07/50] mmc: s3cmci: include linux/interrupt.h for tasklet_struct Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 04/50] IB/mlx5: Assign DSCP for R-RoCE QPs Address Path Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 05/50] PM / wakeirq: report a wakeup_event on dedicated wekup irq Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 06/50] scsi: megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` Levin, Alexander (Sasha Levin) [this message]
2017-10-07 22:36 ` [PATCH review for 4.9 10/50] bnxt_en: Added PCI IDs for BCM57452 and BCM57454 ASICs Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 08/50] mfd: ab8500-sysctrl: Handle probe deferral Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 09/50] mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 15/50] ext4: do not use stripe_width if it is not set Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 14/50] ext4: fix stripe-unaligned allocations Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 13/50] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 12/50] PCI/MSI: Return failure when msix_setup_entries() fails Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 18/50] drm/amdgpu: when dpm disabled, also need to stop/start vce Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 19/50] perf tools: Only increase index if perf_evsel__new_idx() succeeds Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 16/50] net/ena: change driver's default timeouts Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 17/50] i2c: riic: correctly finish transfers Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 23/50] net: phy: dp83867: Recover from "port mirroring" N/A MODE4 Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 22/50] clocksource/drivers/arm_arch_timer: Add dt binding for hisilicon-161010101 erratum Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 20/50] iwlwifi: mvm: use the PROBE_RESP_QUEUE to send deauth to unknown station Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 21/50] drm/fsl-dcu: check for clk_prepare_enable() error Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 24/50] [media] cx231xx: Fix I2C on Internal Master 3 Bus Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 27/50] drm/msm/dsi: Set msm_dsi->encoders before initializing bridge Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 25/50] ath10k: fix reading sram contents for QCA4019 Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 28/50] mtd: nand: sunxi: Fix the non-polling case in sunxi_nfc_wait_events() Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 26/50] clk: sunxi-ng: Check kzalloc() for errors and cleanup error path Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 29/50] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 32/50] scsi: aacraid: Process Error for response I/O Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf() Levin, Alexander (Sasha Levin)
2017-10-10 12:49 ` Boris Ostrovsky
2017-10-24 1:39 ` Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 30/50] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 36/50] staging: lustre: ptlrpc: skip lock if export failed Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 35/50] staging: lustre: hsm: stack overrun in hai_dump_data_field Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 33/50] platform/x86: intel_mid_thermal: Fix module autoload Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 34/50] staging: lustre: llite: don't invoke direct_IO for the EOF case Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 37/50] staging: lustre: lmv: Error not handled for lmv_find_target Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 40/50] vfs: open() with O_CREAT should not create inodes with unknown ids Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 38/50] brcmfmac: check brcmf_bus_get_memdump result for error Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 39/50] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches Levin, Alexander (Sasha Levin)
2017-10-09 8:36 ` Mark Brown
2017-10-24 2:12 ` Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 41/50] ASoC: Intel: boards: remove .pm_ops in all Atom/DPCM machine drivers Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 44/50] s390/dasd: check for device error pointer within state change interrupts Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 43/50] mei: return error on notification request to a disconnected client Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 42/50] [media] exynos4-is: fimc-is: Unmap region obtained by of_iomap() Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 47/50] [media] bt8xx: fix memory leak Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 46/50] s390/crypto: Extend key length check for AES-XTS in fips mode Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 45/50] s390/prng: Adjust generation of entropy to produce real 256 bits Levin, Alexander (Sasha Levin)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007223636.24797-11-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®