mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Gary R Hook <gary.hook@amd.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Subject: [PATCH review for 4.9 02/50] crypto: ccp - Set the AES size field for all modes
Date: Sat, 7 Oct 2017 22:36:46 +0000	[thread overview]
Message-ID: <20171007223636.24797-2-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171007223636.24797-1-alexander.levin@verizon.com>

From: Gary R Hook <gary.hook@amd.com>

[ Upstream commit f7cc02b3c3a33a10dd5bb9e5dfd22e47e09503a2 ]

Ensure that the size field is correctly populated for
all AES modes.

Signed-off-by: Gary R Hook <gary.hook@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
 drivers/crypto/ccp/ccp-dev.h    | 1 +
 drivers/crypto/ccp/ccp-ops.c    | 8 ++++++++
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
index 17b19a68e269..71980c41283b 100644
--- a/drivers/crypto/ccp/ccp-dev-v5.c
+++ b/drivers/crypto/ccp/ccp-dev-v5.c
@@ -278,8 +278,7 @@ static int ccp5_perform_aes(struct ccp_op *op)
 	CCP_AES_ENCRYPT(&function) = op->u.aes.action;
 	CCP_AES_MODE(&function) = op->u.aes.mode;
 	CCP_AES_TYPE(&function) = op->u.aes.type;
-	if (op->u.aes.mode == CCP_AES_MODE_CFB)
-		CCP_AES_SIZE(&function) = 0x7f;
+	CCP_AES_SIZE(&function) = op->u.aes.size;
 
 	CCP5_CMD_FUNCTION(&desc) = function.raw;
 
diff --git a/drivers/crypto/ccp/ccp-dev.h b/drivers/crypto/ccp/ccp-dev.h
index e23c36c7691c..347b77108baa 100644
--- a/drivers/crypto/ccp/ccp-dev.h
+++ b/drivers/crypto/ccp/ccp-dev.h
@@ -470,6 +470,7 @@ struct ccp_aes_op {
 	enum ccp_aes_type type;
 	enum ccp_aes_mode mode;
 	enum ccp_aes_action action;
+	unsigned int size;
 };
 
 struct ccp_xts_aes_op {
diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 64deb006c3be..7d4cd518e602 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -692,6 +692,14 @@ static int ccp_run_aes_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
 			goto e_ctx;
 		}
 	}
+	switch (aes->mode) {
+	case CCP_AES_MODE_CFB: /* CFB128 only */
+	case CCP_AES_MODE_CTR:
+		op.u.aes.size = AES_BLOCK_SIZE * BITS_PER_BYTE - 1;
+		break;
+	default:
+		op.u.aes.size = 0;
+	}
 
 	/* Prepare the input and output data workareas. For in-place
 	 * operations we need to set the dma direction to BIDIRECTIONAL
-- 
2.11.0

  reply	other threads:[~2017-10-07 22:56 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07 22:36 [PATCH review for 4.9 01/50] cpufreq: Do not clear real_cpus mask on policy init Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` Levin, Alexander (Sasha Levin) [this message]
2017-10-07 22:36 ` [PATCH review for 4.9 03/50] staging: fsl-mc: Add missing header Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 04/50] IB/mlx5: Assign DSCP for R-RoCE QPs Address Path Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 07/50] mmc: s3cmci: include linux/interrupt.h for tasklet_struct Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 06/50] scsi: megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 05/50] PM / wakeirq: report a wakeup_event on dedicated wekup irq Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 11/50] staging: rtl8712u: Fix endian settings for structs describing network packets Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 10/50] bnxt_en: Added PCI IDs for BCM57452 and BCM57454 ASICs Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 08/50] mfd: ab8500-sysctrl: Handle probe deferral Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 09/50] mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 13/50] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 15/50] ext4: do not use stripe_width if it is not set Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 12/50] PCI/MSI: Return failure when msix_setup_entries() fails Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 14/50] ext4: fix stripe-unaligned allocations Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 19/50] perf tools: Only increase index if perf_evsel__new_idx() succeeds Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 16/50] net/ena: change driver's default timeouts Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 18/50] drm/amdgpu: when dpm disabled, also need to stop/start vce Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 17/50] i2c: riic: correctly finish transfers Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 22/50] clocksource/drivers/arm_arch_timer: Add dt binding for hisilicon-161010101 erratum Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 23/50] net: phy: dp83867: Recover from "port mirroring" N/A MODE4 Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 20/50] iwlwifi: mvm: use the PROBE_RESP_QUEUE to send deauth to unknown station Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 21/50] drm/fsl-dcu: check for clk_prepare_enable() error Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 28/50] mtd: nand: sunxi: Fix the non-polling case in sunxi_nfc_wait_events() Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 24/50] [media] cx231xx: Fix I2C on Internal Master 3 Bus Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 26/50] clk: sunxi-ng: Check kzalloc() for errors and cleanup error path Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 25/50] ath10k: fix reading sram contents for QCA4019 Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 27/50] drm/msm/dsi: Set msm_dsi->encoders before initializing bridge Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 32/50] scsi: aacraid: Process Error for response I/O Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf() Levin, Alexander (Sasha Levin)
2017-10-10 12:49   ` Boris Ostrovsky
2017-10-24  1:39     ` Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 29/50] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 30/50] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 33/50] platform/x86: intel_mid_thermal: Fix module autoload Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 36/50] staging: lustre: ptlrpc: skip lock if export failed Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 35/50] staging: lustre: hsm: stack overrun in hai_dump_data_field Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 34/50] staging: lustre: llite: don't invoke direct_IO for the EOF case Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 38/50] brcmfmac: check brcmf_bus_get_memdump result for error Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 37/50] staging: lustre: lmv: Error not handled for lmv_find_target Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 39/50] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches Levin, Alexander (Sasha Levin)
2017-10-09  8:36   ` Mark Brown
2017-10-24  2:12     ` Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 40/50] vfs: open() with O_CREAT should not create inodes with unknown ids Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 43/50] mei: return error on notification request to a disconnected client Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 41/50] ASoC: Intel: boards: remove .pm_ops in all Atom/DPCM machine drivers Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 44/50] s390/dasd: check for device error pointer within state change interrupts Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 42/50] [media] exynos4-is: fimc-is: Unmap region obtained by of_iomap() Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 46/50] s390/crypto: Extend key length check for AES-XTS in fips mode Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 47/50] [media] bt8xx: fix memory leak Levin, Alexander (Sasha Levin)
2017-10-07 22:36 ` [PATCH review for 4.9 45/50] s390/prng: Adjust generation of entropy to produce real 256 bits Levin, Alexander (Sasha Levin)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171007223636.24797-2-alexander.levin@verizon.com \
    --to=alexander.levin@verizon.com \
    --cc=gary.hook@amd.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®