[PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE

[PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE

[Cao jin]

As kbuild document & commit 6588169d51 says: KBUILD_{C,LD}FLAGS_MODULE are
used to add arch-specific options for $(CC) and $(LD). From commandline,
{C,LD}FLAGS_MODULE shall be used.
Doesn't have any functional change, but just follow kbuild rules.

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
CC: Russell King <linux@armlinux.org.uk>
CC: linux-arm-kernel@lists.infradead.org
---
 arch/arm/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 47d3a1a..a945b1f 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -16,11 +16,11 @@ LDFLAGS		:=
 LDFLAGS_vmlinux	:=-p --no-undefined -X --pic-veneer
 ifeq ($(CONFIG_CPU_ENDIAN_BE8),y)
 LDFLAGS_vmlinux	+= --be8
-LDFLAGS_MODULE	+= --be8
+KBUILD_LDFLAGS_MODULE	+= --be8
 endif
 
 ifeq ($(CONFIG_ARM_MODULE_PLTS),y)
-LDFLAGS_MODULE	+= -T $(srctree)/arch/arm/kernel/module.lds
+KBUILD_LDFLAGS_MODULE	+= -T $(srctree)/arch/arm/kernel/module.lds
 endif
 
 GZFLAGS		:=-9
@@ -120,7 +120,7 @@ CFLAGS_ISA	:=-mthumb $(AFLAGS_AUTOIT) $(AFLAGS_NOWARN)
 AFLAGS_ISA	:=$(CFLAGS_ISA) -Wa$(comma)-mthumb
 # Work around buggy relocation from gas if requested:
 ifeq ($(CONFIG_THUMB2_AVOID_R_ARM_THM_JUMP11),y)
-CFLAGS_MODULE	+=-fno-optimize-sibling-calls
+KBUILD_CFLAGS_MODULE	+=-fno-optimize-sibling-calls
 endif
 else
 CFLAGS_ISA	:=$(call cc-option,-marm,)
-- 
2.1.0

[PATCH 2/3] c6x/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

[Cao jin]

As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
used to add arch-specific options for $(CC). From commandline,
CFLAGS_MODULE shall be used.
Doesn't have any functional change, but just follow kbuild rules.

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
CC: Mark Salter <msalter@redhat.com>
CC: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
CC: linux-c6x-dev@linux-c6x.org
---
 arch/c6x/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/c6x/Makefile b/arch/c6x/Makefile
index 6b0be67..6f6096f 100644
--- a/arch/c6x/Makefile
+++ b/arch/c6x/Makefile
@@ -12,7 +12,7 @@ cflags-y += -mno-dsbt -msdata=none -D__linux__
 
 cflags-$(CONFIG_C6X_BIG_KERNEL) += -mlong-calls
 
-CFLAGS_MODULE   += -mlong-calls -mno-dsbt -msdata=none
+KBUILD_CFLAGS_MODULE   += -mlong-calls -mno-dsbt -msdata=none
 
 CHECKFLAGS      +=
 
-- 
2.1.0

Re: [PATCH 2/3] c6x/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

[Masahiro Yamada]

2017-10-09 16:11 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
> used to add arch-specific options for $(CC). From commandline,
> CFLAGS_MODULE shall be used.
> Doesn't have any functional change, but just follow kbuild rules.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> CC: Mark Salter <msalter@redhat.com>
> CC: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
> CC: linux-c6x-dev@linux-c6x.org
> ---

Applied to linux-kbuild.  Thanks!


>  arch/c6x/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/c6x/Makefile b/arch/c6x/Makefile
> index 6b0be67..6f6096f 100644
> --- a/arch/c6x/Makefile
> +++ b/arch/c6x/Makefile
> @@ -12,7 +12,7 @@ cflags-y += -mno-dsbt -msdata=none -D__linux__
>
>  cflags-$(CONFIG_C6X_BIG_KERNEL) += -mlong-calls
>
> -CFLAGS_MODULE   += -mlong-calls -mno-dsbt -msdata=none
> +KBUILD_CFLAGS_MODULE   += -mlong-calls -mno-dsbt -msdata=none
>
>  CHECKFLAGS      +=
>
> --
> 2.1.0
>
>
>



-- 
Best Regards
Masahiro Yamada

[PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

[Cao jin]

As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
used to add arch-specific options for $(CC). From commandline,
CFLAGS_MODULE shall be used.
Doesn't have any functional change, but just follow kbuild rules.

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
CC: Richard Kuo <rkuo@codeaurora.org>
CC: linux-hexagon@vger.kernel.org
---
 arch/hexagon/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
index 207711a0..4f5c84c 100644
--- a/arch/hexagon/Makefile
+++ b/arch/hexagon/Makefile
@@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums
 
 # Modules must use either long-calls, or use pic/plt.
 # Use long-calls for now, it's easier.  And faster.
-# CFLAGS_MODULE += -fPIC
-# LDFLAGS_MODULE += -shared
-CFLAGS_MODULE += -mlong-calls
+# KBUILD_CFLAGS_MODULE += -fPIC
+# KBUILD_LDFLAGS_MODULE += -shared
+KBUILD_CFLAGS_MODULE += -mlong-calls
 
 cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
 aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
-- 
2.1.0

Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

[Richard Kuo]

On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote:
> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
> used to add arch-specific options for $(CC). From commandline,
> CFLAGS_MODULE shall be used.
> Doesn't have any functional change, but just follow kbuild rules.
> 
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> CC: Richard Kuo <rkuo@codeaurora.org>
> CC: linux-hexagon@vger.kernel.org
> ---
>  arch/hexagon/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
> index 207711a0..4f5c84c 100644
> --- a/arch/hexagon/Makefile
> +++ b/arch/hexagon/Makefile
> @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums
>  
>  # Modules must use either long-calls, or use pic/plt.
>  # Use long-calls for now, it's easier.  And faster.
> -# CFLAGS_MODULE += -fPIC
> -# LDFLAGS_MODULE += -shared
> -CFLAGS_MODULE += -mlong-calls
> +# KBUILD_CFLAGS_MODULE += -fPIC
> +# KBUILD_LDFLAGS_MODULE += -shared
> +KBUILD_CFLAGS_MODULE += -mlong-calls
>  
>  cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
>  aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
> -- 
> 2.1.0
> 
> 
> 

For Hexagon:

Acked-by: Richard Kuo <rkuo@codeaurora.org>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

[Masahiro Yamada]

2017-10-10 10:26 GMT+09:00 Richard Kuo <rkuo@codeaurora.org>:
> On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote:
>> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
>> used to add arch-specific options for $(CC). From commandline,
>> CFLAGS_MODULE shall be used.
>> Doesn't have any functional change, but just follow kbuild rules.
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> CC: Richard Kuo <rkuo@codeaurora.org>
>> CC: linux-hexagon@vger.kernel.org
>> ---
>>  arch/hexagon/Makefile | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
>> index 207711a0..4f5c84c 100644
>> --- a/arch/hexagon/Makefile
>> +++ b/arch/hexagon/Makefile
>> @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums
>>
>>  # Modules must use either long-calls, or use pic/plt.
>>  # Use long-calls for now, it's easier.  And faster.
>> -# CFLAGS_MODULE += -fPIC
>> -# LDFLAGS_MODULE += -shared
>> -CFLAGS_MODULE += -mlong-calls
>> +# KBUILD_CFLAGS_MODULE += -fPIC
>> +# KBUILD_LDFLAGS_MODULE += -shared
>> +KBUILD_CFLAGS_MODULE += -mlong-calls
>>
>>  cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
>>  aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
>> --
>> 2.1.0
>>
>>
>>
>
> For Hexagon:
>
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
>


Applied to linux-kbuild.  Thanks!


-- 
Best Regards
Masahiro Yamada

Re: [PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE

[Masahiro Yamada]

2017-10-09 16:11 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> As kbuild document & commit 6588169d51 says: KBUILD_{C,LD}FLAGS_MODULE are
> used to add arch-specific options for $(CC) and $(LD). From commandline,
> {C,LD}FLAGS_MODULE shall be used.
> Doesn't have any functional change, but just follow kbuild rules.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> CC: Russell King <linux@armlinux.org.uk>
> CC: linux-arm-kernel@lists.infradead.org

Applied to linux-kbuild.  Thanks!


> ---
>  arch/arm/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 47d3a1a..a945b1f 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -16,11 +16,11 @@ LDFLAGS             :=
>  LDFLAGS_vmlinux        :=-p --no-undefined -X --pic-veneer
>  ifeq ($(CONFIG_CPU_ENDIAN_BE8),y)
>  LDFLAGS_vmlinux        += --be8
> -LDFLAGS_MODULE += --be8
> +KBUILD_LDFLAGS_MODULE  += --be8
>  endif
>
>  ifeq ($(CONFIG_ARM_MODULE_PLTS),y)
> -LDFLAGS_MODULE += -T $(srctree)/arch/arm/kernel/module.lds
> +KBUILD_LDFLAGS_MODULE  += -T $(srctree)/arch/arm/kernel/module.lds
>  endif
>
>  GZFLAGS                :=-9
> @@ -120,7 +120,7 @@ CFLAGS_ISA  :=-mthumb $(AFLAGS_AUTOIT) $(AFLAGS_NOWARN)
>  AFLAGS_ISA     :=$(CFLAGS_ISA) -Wa$(comma)-mthumb
>  # Work around buggy relocation from gas if requested:
>  ifeq ($(CONFIG_THUMB2_AVOID_R_ARM_THM_JUMP11),y)
> -CFLAGS_MODULE  +=-fno-optimize-sibling-calls
> +KBUILD_CFLAGS_MODULE   +=-fno-optimize-sibling-calls
>  endif
>  else
>  CFLAGS_ISA     :=$(call cc-option,-marm,)
> --
> 2.1.0
>
>
>



-- 
Best Regards
Masahiro Yamada