mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>,
	Jonathan McDowell <noodles@earth.li>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid dependencies
Date: Thu, 12 Oct 2017 10:16:34 +0200	[thread overview]
Message-ID: <20171012081634.5xu2vtmmt3hbqohp@gmail.com> (raw)
In-Reply-To: <20171012080733.4y5wlghjr524cgr3@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> > +	bool changed;
> > +	__u32 disable[NCAPINTS + NBUGINTS];
> > +	unsigned long *disable_mask = (unsigned long *)disable;
> > +	const struct cpuid_dep *d;
> 
> The constant forced types are really ugly and permeate the whole code. Please 
> introduce some suitably named helpers in the x86 bitops file that work on local 
> variables:
> 
> 	var &= ~(1<<bit);
> 	var |= 1<<bit;

So instead of adding helpers the 1<< ops can be written out explicitly - they are 
easy to read after all. Can also be:

	var &= ~BIT(bit);
	var |= BIT(bit);

Thanks,

	Ingo

  reply	other threads:[~2017-10-12  8:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07  0:03 Support generic disabling of all XSAVE features Andi Kleen
2017-10-07  0:03 ` [PATCH v9 1/5] x86/xsave: Move xsave initialization to after parsing early parameters Andi Kleen
2017-10-12  7:18   ` Ingo Molnar
2017-10-07  0:03 ` [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid dependencies Andi Kleen
2017-10-08  8:35   ` Thomas Gleixner
2017-10-12  8:07   ` Ingo Molnar
2017-10-12  8:16     ` Ingo Molnar [this message]
2017-10-13 17:46       ` Andi Kleen
2017-10-12 15:13     ` Thomas Gleixner
2017-10-12 22:01       ` Andi Kleen
2017-10-13  5:30       ` Ingo Molnar
2017-10-13 16:36         ` Andi Kleen
2017-10-12 22:12     ` Andi Kleen
2017-10-07  0:03 ` [PATCH v9 3/5] x86/cpuid: Make clearcpuid an early param Andi Kleen
2017-10-12  8:09   ` Ingo Molnar
2017-10-07  0:03 ` [PATCH v9 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling Andi Kleen
2017-10-08  8:34   ` Thomas Gleixner
2017-10-12  8:11   ` Ingo Molnar
2017-10-13 17:48     ` Andi Kleen
2017-10-07  0:03 ` [PATCH v9 5/5] x86/xsave: Remove the explicit clearing of XSAVE dependend features Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012081634.5xu2vtmmt3hbqohp@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noodles@earth.li \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®