From: David Miller <davem@davemloft.net>
To: boris.ostrovsky@oracle.com
Cc: wei.liu2@citrix.com, mgamal@redhat.com, netdev@vger.kernel.org,
xen-devel@lists.xenproject.org, paul.durrant@citrix.com,
linux-kernel@vger.kernel.org, vkuznets@redhat.com,
otubo@redhat.com, cavery@redhat.com, cheshi@redhat.com,
jgross@suse.com
Subject: Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values
Date: Mon, 16 Oct 2017 21:22:23 +0100 (WEST) [thread overview]
Message-ID: <20171016.212223.777323721927998324.davem@davemloft.net> (raw)
In-Reply-To: <3da3d5ae-c2cb-380e-368d-a90432608cf1@oracle.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Date: Mon, 16 Oct 2017 16:19:07 -0400
> On 10/16/2017 11:05 AM, Wei Liu wrote:
>> On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote:
>>> RFC791 specifies the minimum MTU to be 68, while xen-net{front|back}
>>> drivers use a minimum value of 0.
>>>
>>> When set MTU to 0~67 with xen_net{front|back} driver, the network
>>> will become unreachable immediately, the guest can no longer be pinged.
>>>
>>> xen_net{front|back} should not allow the user to set this value which causes
>>> network problems.
>>>
>>> Reported-by: Chen Shi <cheshi@redhat.com>
>>> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
>> Acked-by: Wei Liu <wei.liu2@citrix.com>
>>
>> CC netfront maintainers
>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> I can take it via Xen tree unless there are objections.
No problem on my end.
prev parent reply other threads:[~2017-10-16 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 13:20 Mohammed Gamal
2017-10-16 14:43 ` Eduardo Otubo
2017-10-16 15:05 ` Wei Liu
2017-10-16 20:19 ` Boris Ostrovsky
2017-10-16 20:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016.212223.777323721927998324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boris.ostrovsky@oracle.com \
--cc=cavery@redhat.com \
--cc=cheshi@redhat.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®