Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()

[Jessica Yu <jeyu@kernel.org>]

+++ SF Markus Elfring [06/10/17 17:12 +0200]:
>From: Markus Elfring <elfring@users.sourceforge.net>
>Date: Fri, 6 Oct 2017 16:27:26 +0200
>
>Omit an extra message for a memory allocation failure in this function.
>
>This issue was detected by using the Coccinelle software.
>
>Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied to modules-next, thanks.

Jessica

>---
> kernel/module.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index de66ec825992..07ef44767245 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -837,10 +837,8 @@ static int add_module_usage(struct module *a, struct module *b)
>
> 	pr_debug("Allocating new usage for %s.\n", a->name);
> 	use = kmalloc(sizeof(*use), GFP_ATOMIC);
>-	if (!use) {
>-		pr_warn("%s: out of memory loading\n", a->name);
>+	if (!use)
> 		return -ENOMEM;
>-	}
>
> 	use->source = a;
> 	use->target = b;
>-- 
>2.14.2
>