mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jessica Yu <jeyu@kernel.org>,
	kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()
Date: Thu, 19 Oct 2017 13:12:21 +0200	[thread overview]
Message-ID: <53f5b946-34a2-fe06-b118-d6c563e838e0@users.sourceforge.net> (raw)
In-Reply-To: <20171019110246.7f5m5ossvq5c5jz7@redbean>

>> This is a small allocation so it can't fail in current kernels.  I can't
>> imagine a situation where this could fail and it wasn't dead easy to
>> debug.  Most modules are loaded at boot so it's not likely to fail, but
>> if it did, it would be easy to reproduce.  If it's not loaded at boot
>> it's probably really easy to tell which module we're loading.
> 
> Yeah, good points. And on second thought, we normally don't print
> warnings for every small alloc failure in the kernel anyway (that
> would be utterly superfluous), the error code itself is sufficient.
> And in the module loader this seems to be the only printk out of the
> dozen alloc calls we do, so I'm OK with removing this one.

Thanks for your constructive feedback.

Can it help to improve the corresponding documentation for Linux
programming interfaces a bit more?

Regards,
Markus

  reply	other threads:[~2017-10-19 11:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 15:12 [PATCH] " SF Markus Elfring
2017-10-19  9:29 ` Jessica Yu
2017-10-19 10:30   ` Dan Carpenter
2017-10-19 11:02     ` Jessica Yu
2017-10-19 11:12       ` SF Markus Elfring [this message]
2017-10-19 10:42   ` SF Markus Elfring
2017-10-19 11:08 ` Jessica Yu
2017-10-19 11:18   ` SF Markus Elfring
2017-10-19 11:29     ` Joe Perches
2017-10-19 11:35       ` SF Markus Elfring
2017-10-19 11:45         ` Joe Perches
2017-10-19 18:56           ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53f5b946-34a2-fe06-b118-d6c563e838e0@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=dan.carpenter@oracle.com \
    --cc=jeyu@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®