[PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

[PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

[Bin Meng]

The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
data. Select it in the Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- Enforce dependency on PCI

 drivers/mtd/spi-nor/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
index f26aaa6..abf453a 100644
--- a/drivers/mtd/spi-nor/Kconfig
+++ b/drivers/mtd/spi-nor/Kconfig
@@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
 
 config SPI_INTEL_SPI_PLATFORM
 	tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
-	depends on X86
+	depends on X86 && PCI
 	select SPI_INTEL_SPI
+	select LPC_ICH
 	help
 	  This enables platform support for the Intel PCH/PCU SPI
 	  controller in master mode. This controller is present in modern
-- 
2.7.4

Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

[Mika Westerberg]

On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote:
> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
> data. Select it in the Kconfig.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> 
> ---
> 
> Changes in v2:
> - Enforce dependency on PCI
> 
>  drivers/mtd/spi-nor/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index f26aaa6..abf453a 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
>  
>  config SPI_INTEL_SPI_PLATFORM
>  	tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> -	depends on X86
> +	depends on X86 && PCI

It is kind of weird to depend on PCI if we want to enable *platform*
driver but whatever. I would still prefer to have dependency for LPC_ICH
instead.

No strong feelings though - as long as it builds and works fine :-)

>  	select SPI_INTEL_SPI
> +	select LPC_ICH
>  	help
>  	  This enables platform support for the Intel PCH/PCU SPI
>  	  controller in master mode. This controller is present in modern
> -- 
> 2.7.4

Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

[Arnd Bergmann]

On Tue, Oct 24, 2017 at 11:21 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote:
>> index f26aaa6..abf453a 100644
>> --- a/drivers/mtd/spi-nor/Kconfig
>> +++ b/drivers/mtd/spi-nor/Kconfig
>> @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
>>
>>  config SPI_INTEL_SPI_PLATFORM
>>       tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
>> -     depends on X86
>> +     depends on X86 && PCI
>
> It is kind of weird to depend on PCI if we want to enable *platform*
> driver but whatever. I would still prefer to have dependency for LPC_ICH
> instead.
>
> No strong feelings though - as long as it builds and works fine :-)

Agreed, I think we are better off using a dependency here, but
then we should probably do that for all users of LPC_ICH and
change them over as well. I think there are two or three other drivers
that currently select LPC_ICH. Using 'select' like this is generally
a bad idea, but being inconsistent (using both depends and select)
is usually worse.

        Arnd