From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Cc: ruxandra.radulescu@nxp.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment
Date: Fri, 27 Oct 2017 17:30:21 +0300 [thread overview]
Message-ID: <20171027143020.m7zlhptw4nl2xy3n@mwanda> (raw)
In-Reply-To: <1509113496-10810-5-git-send-email-bogdan.purcareata@nxp.com>
On Fri, Oct 27, 2017 at 02:11:35PM +0000, Bogdan Purcareata wrote:
> @@ -93,10 +100,10 @@
> * buffers large enough to allow building an skb around them and also account
> * for alignment restrictions
> */
> -#define DPAA2_ETH_BUF_RAW_SIZE \
> +#define DPAA2_ETH_BUF_RAW_SIZE(priv) \
> (DPAA2_ETH_RX_BUF_SIZE + \
> SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) + \
> - DPAA2_ETH_RX_BUF_ALIGN)
> + (priv)->rx_buf_align)
>
Not related to this patch, but this macro is ugly. It would be better
as function.
regards,
dan carpenter
next prev parent reply other threads:[~2017-10-27 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 14:11 [PATCH 0/5] staging: fsl-dpaa2/eth: Frame buffer work Bogdan Purcareata
2017-10-27 14:11 ` [PATCH 1/5] staging: fsl-dpaa2/eth: Label cleanup Bogdan Purcareata
2017-10-27 14:11 ` [PATCH 2/5] staging: fsl-dpaa2/eth: Split function Bogdan Purcareata
2017-10-27 14:11 ` [PATCH 3/5] staging: fsl-dpaa2/eth: Don't account SWA in tx_data_offset Bogdan Purcareata
2017-10-27 14:26 ` Dan Carpenter
2017-10-27 14:31 ` Bogdan Purcareata
2017-10-27 14:34 ` Dan Carpenter
2017-10-27 14:42 ` Bogdan Purcareata
2017-10-27 14:11 ` [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment Bogdan Purcareata
2017-10-27 14:30 ` Dan Carpenter [this message]
2017-10-27 14:44 ` Bogdan Purcareata
2017-10-30 8:55 ` Dan Carpenter
2017-10-30 9:16 ` Bogdan Purcareata
2017-10-27 14:11 ` [PATCH 5/5] staging: fsl-dpaa2/eth: Extra headroom in RX buffers Bogdan Purcareata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027143020.m7zlhptw4nl2xy3n@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bogdan.purcareata@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®