* [PATCH] ASoC: stm32: sai: attempt to fix uninitialized variable
@ 2017-11-02 11:15 Arnd Bergmann
2017-11-02 11:21 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-11-02 11:15 UTC (permalink / raw)
To: Mark Brown
Cc: Arnd Bergmann, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Maxime Coquelin, Alexandre Torgue, Olivier Moysan, Dan Carpenter,
alsa-devel, linux-arm-kernel, linux-kernel
After commit 61fb4ff70377 ("ASoC: stm32: sai: Move static
settings to DAI init"), we get a valid warning about the
use of an uninitialized variable:
sound/soc/stm/stm32_sai_sub.c: In function 'stm32_sai_hw_params':
sound/soc/stm/stm32_sai_sub.c:485:7: error: 'cr1' may be used uninitialized in this function [-Werror=maybe-uninitialized]
I could not immediately figure out what the code should do
instead, this is the hack I applied locally to shut up the
warning. It may or may not be correct, please take a look.
Fixes: 61fb4ff70377 ("ASoC: stm32: sai: Move static settings to DAI init")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/stm/stm32_sai_sub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c
index 150ad546d8b9..d8a51fce368a 100644
--- a/sound/soc/stm/stm32_sai_sub.c
+++ b/sound/soc/stm/stm32_sai_sub.c
@@ -480,6 +480,7 @@ static int stm32_sai_set_config(struct snd_soc_dai *cpu_dai,
/* Mode, data format and channel config */
cr1_mask = SAI_XCR1_DS_MASK;
+ cr1 = 0;
switch (params_format(params)) {
case SNDRV_PCM_FORMAT_S8:
cr1 |= SAI_XCR1_DS_SET(SAI_DATASIZE_8);
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: stm32: sai: attempt to fix uninitialized variable
2017-11-02 11:15 [PATCH] ASoC: stm32: sai: attempt to fix uninitialized variable Arnd Bergmann
@ 2017-11-02 11:21 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2017-11-02 11:21 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Maxime Coquelin,
Alexandre Torgue, Olivier Moysan, Dan Carpenter, alsa-devel,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
On Thu, Nov 02, 2017 at 12:15:48PM +0100, Arnd Bergmann wrote:
> After commit 61fb4ff70377 ("ASoC: stm32: sai: Move static
> settings to DAI init"), we get a valid warning about the
> use of an uninitialized variable:
A fix was already sent for this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-02 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 11:15 [PATCH] ASoC: stm32: sai: attempt to fix uninitialized variable Arnd Bergmann
2017-11-02 11:21 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®