Re: [PATCH v9 3/3] MIPS: ranchu: Add Ranchu as a new generic-based board

[James Hogan <james.hogan@mips.com>]

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

Hi Aleksandar,

On Wed, Nov 15, 2017 at 02:42:20PM +0100, Aleksandar Markovic wrote:
> diff --git a/arch/mips/configs/generic/board-ranchu.config b/arch/mips/configs/generic/board-ranchu.config
> new file mode 100644
> index 0000000..fee9ad4
> --- /dev/null
> +++ b/arch/mips/configs/generic/board-ranchu.config
> @@ -0,0 +1,30 @@
> +CONFIG_VIRT_BOARD_RANCHU=y

I presume its valid for Ranchu support to be enabled in MIPS32 / MIPS64,
and R1 / R2 / R6 kernels? (that's fine if so, just making sure there's
no need for a require comment).

> diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c
> new file mode 100644
> index 0000000..0efc555
> --- /dev/null
> +++ b/arch/mips/generic/board-ranchu.c
> @@ -0,0 +1,85 @@

...

> +static __init unsigned int ranchu_measure_hpt_freq(void)
> +{

...

> +	count += 5000;	/* round */
> +	count -= count % 10000;

A comment to explain the purpose of the rounding would be helpful. I
presume its there just to get a more accurate value since the frequency
will always be a round value in practice.

Either way this patch looks good to me:
Reviewed-by: James Hogan <jhogan@kernel.org>

Thanks!
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]