* [PATCH] mfd: ti_am335x_tscadc: remove redundant assignment to node
@ 2017-10-29 12:58 Colin King
2017-11-29 10:59 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-29 12:58 UTC (permalink / raw)
To: Lee Jones, linux-kernel; +Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Node is being initialized a value that is never read, it is
being written over a few statements into the function with
the return value from call to of_get_child_by_name. Hence
this initialization can be removed. Cleans up clang warning:
drivers/mfd/ti_am335x_tscadc.c:127:22: warning: Value stored
to 'node' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mfd/ti_am335x_tscadc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
index 0f3fab47fe48..3cd958a31f36 100644
--- a/drivers/mfd/ti_am335x_tscadc.c
+++ b/drivers/mfd/ti_am335x_tscadc.c
@@ -124,7 +124,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
struct ti_tscadc_dev *tscadc;
struct resource *res;
struct clk *clk;
- struct device_node *node = pdev->dev.of_node;
+ struct device_node *node;
struct mfd_cell *cell;
struct property *prop;
const __be32 *cur;
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: ti_am335x_tscadc: remove redundant assignment to node
2017-10-29 12:58 [PATCH] mfd: ti_am335x_tscadc: remove redundant assignment to node Colin King
@ 2017-11-29 10:59 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-11-29 10:59 UTC (permalink / raw)
To: Colin King; +Cc: linux-kernel, kernel-janitors
On Sun, 29 Oct 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Node is being initialized a value that is never read, it is
> being written over a few statements into the function with
> the return value from call to of_get_child_by_name. Hence
> this initialization can be removed. Cleans up clang warning:
>
> drivers/mfd/ti_am335x_tscadc.c:127:22: warning: Value stored
> to 'node' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-29 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-29 12:58 [PATCH] mfd: ti_am335x_tscadc: remove redundant assignment to node Colin King
2017-11-29 10:59 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®