* [PATCH] quota: Check for register_shrinker() failure.
@ 2017-11-29 13:34 Tetsuo Handa
2017-11-29 13:42 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Tetsuo Handa @ 2017-11-29 13:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Tetsuo Handa, Jan Kara, Michal Hocko
register_shrinker() might return -ENOMEM error since Linux 3.12.
Call panic() as with other failure checks in this function if
register_shrinker() failed.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Jan Kara <jack@suse.com>
Cc: Michal Hocko <mhocko@suse.com>
---
fs/quota/dquot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 39f1b0b..1429f03 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2985,7 +2985,8 @@ static int __init dquot_init(void)
pr_info("VFS: Dquot-cache hash table entries: %ld (order %ld,"
" %ld bytes)\n", nr_hash, order, (PAGE_SIZE << order));
- register_shrinker(&dqcache_shrinker);
+ if (register_shrinker(&dqcache_shrinker))
+ panic("Cannot register dquot shrinker");
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] quota: Check for register_shrinker() failure.
2017-11-29 13:34 [PATCH] quota: Check for register_shrinker() failure Tetsuo Handa
@ 2017-11-29 13:42 ` Michal Hocko
2017-11-29 15:48 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2017-11-29 13:42 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: linux-kernel, Jan Kara
On Wed 29-11-17 22:34:50, Tetsuo Handa wrote:
> register_shrinker() might return -ENOMEM error since Linux 3.12.
> Call panic() as with other failure checks in this function if
> register_shrinker() failed.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: 1d3d4437eae1 ("vmscan: per-node deferred work")
> Cc: Jan Kara <jack@suse.com>
> Cc: Michal Hocko <mhocko@suse.com>
>From my very limited understanding of the code this looks correct.
FWIW
Reviewed-by: Michal Hocko <mhocko@suse.com>
> ---
> fs/quota/dquot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index 39f1b0b..1429f03 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -2985,7 +2985,8 @@ static int __init dquot_init(void)
> pr_info("VFS: Dquot-cache hash table entries: %ld (order %ld,"
> " %ld bytes)\n", nr_hash, order, (PAGE_SIZE << order));
>
> - register_shrinker(&dqcache_shrinker);
> + if (register_shrinker(&dqcache_shrinker))
> + panic("Cannot register dquot shrinker");
>
> return 0;
> }
> --
> 1.8.3.1
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] quota: Check for register_shrinker() failure.
2017-11-29 13:42 ` Michal Hocko
@ 2017-11-29 15:48 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2017-11-29 15:48 UTC (permalink / raw)
To: Michal Hocko; +Cc: Tetsuo Handa, linux-kernel, Jan Kara
On Wed 29-11-17 14:42:51, Michal Hocko wrote:
> On Wed 29-11-17 22:34:50, Tetsuo Handa wrote:
> > register_shrinker() might return -ENOMEM error since Linux 3.12.
> > Call panic() as with other failure checks in this function if
> > register_shrinker() failed.
> >
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>
> Fixes: 1d3d4437eae1 ("vmscan: per-node deferred work")
>
> > Cc: Jan Kara <jack@suse.com>
> > Cc: Michal Hocko <mhocko@suse.com>
>
> From my very limited understanding of the code this looks correct.
> FWIW
> Reviewed-by: Michal Hocko <mhocko@suse.com>
Thanks. Added to my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-29 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 13:34 [PATCH] quota: Check for register_shrinker() failure Tetsuo Handa
2017-11-29 13:42 ` Michal Hocko
2017-11-29 15:48 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®