* [PATCH] KVM: x86: MMU: make array audit_point_name static
@ 2017-11-30 12:04 Colin King
2017-11-30 16:14 ` Paolo Bonzini
2017-12-04 10:41 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-11-30 12:04 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář,
Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, kvm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The array audit_point_name is local to the source and does not need to
be in global scope, so make it static.
Cleans up sparse warning:
arch/x86/kvm/mmu_audit.c:22:12: warning: symbol 'audit_point_name' was
not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/kvm/mmu_audit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/mmu_audit.c b/arch/x86/kvm/mmu_audit.c
index d22ddbdf5e6e..1272861e77b9 100644
--- a/arch/x86/kvm/mmu_audit.c
+++ b/arch/x86/kvm/mmu_audit.c
@@ -19,7 +19,7 @@
#include <linux/ratelimit.h>
-char const *audit_point_name[] = {
+static char const *audit_point_name[] = {
"pre page fault",
"post page fault",
"pre pte write",
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: x86: MMU: make array audit_point_name static
2017-11-30 12:04 [PATCH] KVM: x86: MMU: make array audit_point_name static Colin King
@ 2017-11-30 16:14 ` Paolo Bonzini
2017-12-04 10:41 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-11-30 16:14 UTC (permalink / raw)
To: Colin King, Radim Krčmář,
Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, kvm
Cc: kernel-janitors, linux-kernel
On 30/11/2017 13:04, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array audit_point_name is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> arch/x86/kvm/mmu_audit.c:22:12: warning: symbol 'audit_point_name' was
> not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/kvm/mmu_audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu_audit.c b/arch/x86/kvm/mmu_audit.c
> index d22ddbdf5e6e..1272861e77b9 100644
> --- a/arch/x86/kvm/mmu_audit.c
> +++ b/arch/x86/kvm/mmu_audit.c
> @@ -19,7 +19,7 @@
>
> #include <linux/ratelimit.h>
>
> -char const *audit_point_name[] = {
> +static char const *audit_point_name[] = {
> "pre page fault",
> "post page fault",
> "pre pte write",
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: x86: MMU: make array audit_point_name static
2017-11-30 12:04 [PATCH] KVM: x86: MMU: make array audit_point_name static Colin King
2017-11-30 16:14 ` Paolo Bonzini
@ 2017-12-04 10:41 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2017-12-04 10:41 UTC (permalink / raw)
To: Colin King, Paolo Bonzini, Radim Krčmář,
Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, kvm
Cc: kernel-janitors, linux-kernel
On 30.11.2017 13:04, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array audit_point_name is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> arch/x86/kvm/mmu_audit.c:22:12: warning: symbol 'audit_point_name' was
> not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/kvm/mmu_audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu_audit.c b/arch/x86/kvm/mmu_audit.c
> index d22ddbdf5e6e..1272861e77b9 100644
> --- a/arch/x86/kvm/mmu_audit.c
> +++ b/arch/x86/kvm/mmu_audit.c
> @@ -19,7 +19,7 @@
>
> #include <linux/ratelimit.h>
>
> -char const *audit_point_name[] = {
> +static char const *audit_point_name[] = {
> "pre page fault",
> "post page fault",
> "pre pte write",
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-04 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 12:04 [PATCH] KVM: x86: MMU: make array audit_point_name static Colin King
2017-11-30 16:14 ` Paolo Bonzini
2017-12-04 10:41 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®