From: Greg KH <gregkh@linuxfoundation.org>
To: "lpc.li" <lpc.li@huawei.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, lidongpo@hisilicon.com
Subject: Re: usb: gadget: function: f_rndis:use dev_kfree_skb_irq instead of dev_kfree_skb
Date: Fri, 22 Dec 2017 09:56:03 +0100 [thread overview]
Message-ID: <20171222085603.GB18475@kroah.com> (raw)
In-Reply-To: <9d873444-19e8-37b2-e08f-d24d89a0959f@huawei.com>
On Fri, Dec 22, 2017 at 04:44:48PM +0800, lpc.li wrote:
> We can't use kfree_skb in irq disable context, because spin_lock_irqsave
> make sure we are always in irq disable context, use dev_kfree_skb_irq
> instead of kfree_skb is better than dev_kfree_skb_any.
Ok, but your patch uses:
> - dev_kfree_skb(skb);
> + dev_kfree_skb_any(skb);
the _any call, not _irq, did you test this?
thanks,
greg k-h
parent reply other threads:[~2017-12-22 9:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <9d873444-19e8-37b2-e08f-d24d89a0959f@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222085603.GB18475@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=lidongpo@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lpc.li@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®