* Re: usb: gadget: function: f_rndis:use dev_kfree_skb_irq instead of dev_kfree_skb
[not found] <9d873444-19e8-37b2-e08f-d24d89a0959f@huawei.com>
@ 2017-12-22 8:56 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2017-12-22 8:56 UTC (permalink / raw)
To: lpc.li; +Cc: balbi, linux-usb, linux-kernel, lidongpo
On Fri, Dec 22, 2017 at 04:44:48PM +0800, lpc.li wrote:
> We can't use kfree_skb in irq disable context, because spin_lock_irqsave
> make sure we are always in irq disable context, use dev_kfree_skb_irq
> instead of kfree_skb is better than dev_kfree_skb_any.
Ok, but your patch uses:
> - dev_kfree_skb(skb);
> + dev_kfree_skb_any(skb);
the _any call, not _irq, did you test this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread