mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: tglx@linuxtronix.de
Cc: torvalds@linux-foundation.org, gregkh@linux-foundation.org,
	dwmw@amazon.co.uk, tim.c.chen@linux.intel.com,
	linux-kernel@vger.kernel.org, dave.hansen@intel.com,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 03/11] x86/retpoline/entry: Convert entry assembler indirect jumps
Date: Wed,  3 Jan 2018 15:09:26 -0800	[thread overview]
Message-ID: <20180103230934.15788-4-andi@firstfloor.org> (raw)
In-Reply-To: <20180103230934.15788-1-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

Convert all indirect jumps in core 32/64bit entry assembler code to use
non speculative sequences.

Based on code from David Woodhouse and Tim Chen

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 arch/x86/entry/entry_32.S |  5 +++--
 arch/x86/entry/entry_64.S | 12 +++++++-----
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S
index ace8f321a5a1..a4b88260d6f7 100644
--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -44,6 +44,7 @@
 #include <asm/asm.h>
 #include <asm/smap.h>
 #include <asm/frame.h>
+#include <asm/jump-asm.h>
 
 	.section .entry.text, "ax"
 
@@ -290,7 +291,7 @@ ENTRY(ret_from_fork)
 
 	/* kernel thread */
 1:	movl	%edi, %eax
-	call	*%ebx
+	NOSPEC_CALL	%ebx
 	/*
 	 * A kernel thread is allowed to return here after successfully
 	 * calling do_execve().  Exit to userspace to complete the execve()
@@ -919,7 +920,7 @@ common_exception:
 	movl	%ecx, %es
 	TRACE_IRQS_OFF
 	movl	%esp, %eax			# pt_regs pointer
-	call	*%edi
+	NOSPEC_CALL	%edi
 	jmp	ret_from_exception
 END(common_exception)
 
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index f048e384ff54..486990fb3e4d 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -37,6 +37,7 @@
 #include <asm/pgtable_types.h>
 #include <asm/export.h>
 #include <asm/frame.h>
+#include <asm/jump-asm.h>
 #include <linux/err.h>
 
 #include "calling.h"
@@ -191,7 +192,7 @@ ENTRY(entry_SYSCALL_64_trampoline)
 	 */
 	pushq	%rdi
 	movq	$entry_SYSCALL_64_stage2, %rdi
-	jmp	*%rdi
+	NOSPEC_JMP	%rdi
 END(entry_SYSCALL_64_trampoline)
 
 	.popsection
@@ -269,8 +270,9 @@ entry_SYSCALL_64_fastpath:
 	 * This call instruction is handled specially in stub_ptregs_64.
 	 * It might end up jumping to the slow path.  If it jumps, RAX
 	 * and all argument registers are clobbered.
-	 */
-	call	*sys_call_table(, %rax, 8)
+	*/
+	movq	sys_call_table(, %rax, 8), %rax
+	NOSPEC_CALL	%rax
 .Lentry_SYSCALL_64_after_fastpath_call:
 
 	movq	%rax, RAX(%rsp)
@@ -442,7 +444,7 @@ ENTRY(stub_ptregs_64)
 	jmp	entry_SYSCALL64_slow_path
 
 1:
-	jmp	*%rax				/* Called from C */
+	NOSPEC_JMP	%rax				/* Called from C */
 END(stub_ptregs_64)
 
 .macro ptregs_stub func
@@ -521,7 +523,7 @@ ENTRY(ret_from_fork)
 1:
 	/* kernel thread */
 	movq	%r12, %rdi
-	call	*%rbx
+	NOSPEC_CALL	%rbx
 	/*
 	 * A kernel thread is allowed to return here after successfully
 	 * calling do_execve().  Exit to userspace to complete the execve()
-- 
2.14.3

  parent reply	other threads:[~2018-01-03 23:09 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 23:09 Avoid speculative indirect calls in kernel Andi Kleen
2018-01-03 23:09 ` [PATCH 01/11] x86/retpoline: Define retpoline indirect thunk and macros Andi Kleen
2018-01-03 23:09 ` [PATCH 02/11] x86/retpoline/crypto: Convert crypto assembler indirect jumps Andi Kleen
2018-01-03 23:09 ` Andi Kleen [this message]
2018-01-03 23:09 ` [PATCH 04/11] x86/retpoline/ftrace: Convert ftrace " Andi Kleen
2018-01-03 23:09 ` [PATCH 05/11] x86/retpoline/hyperv: Convert " Andi Kleen
2018-01-03 23:09 ` [PATCH 06/11] x86/retpoline/crypto: Convert xen " Andi Kleen
2018-01-03 23:09 ` [PATCH 07/11] x86/retpoline/checksum32: Convert " Andi Kleen
2018-01-03 23:09 ` [PATCH 08/11] x86/retpoline/irq32: " Andi Kleen
2018-01-03 23:09 ` [PATCH 09/11] x86/retpoline: Finally enable retpoline for C code Andi Kleen
2018-01-04  8:28   ` Greg KH
2018-01-04  8:30     ` Dave Hansen
2018-01-03 23:09 ` [PATCH 10/11] retpoline/taint: Taint kernel for missing retpoline in compiler Andi Kleen
2018-01-04  0:29   ` Thomas Gleixner
2018-01-04  0:35     ` Randy Dunlap
2018-01-03 23:09 ` [PATCH 11/11] retpoline/objtool: Disable some objtool warnings Andi Kleen
2018-01-03 23:51 ` Avoid speculative indirect calls in kernel Linus Torvalds
2018-01-04  0:00   ` Alan Cox
2018-01-04  0:09   ` Andi Kleen
2018-01-04  0:12     ` Thomas Gleixner
2018-01-04  0:15       ` Andi Kleen
2018-01-04  0:19         ` Jiri Kosina
2018-01-05  2:01           ` james harvey
2018-01-05 10:40             ` Woodhouse, David
2018-01-05 12:29               ` james harvey
2018-01-05 12:06             ` Alan Cox
2018-01-04  0:29         ` Alan Cox
2018-01-04  0:31           ` Thomas Gleixner
2018-01-04  0:38             ` Alan Cox
2018-01-04  0:40             ` Andi Kleen
2018-01-04  8:15               ` Woodhouse, David
2018-01-04 15:53                 ` Andi Kleen
2018-01-04 15:55                   ` Woodhouse, David
2018-01-04  0:20       ` Linus Torvalds
2018-01-04  0:26         ` Thomas Gleixner
2018-01-04  0:18     ` David Lang
2018-01-04  1:00   ` Paul Turner
2018-01-04  1:41   ` Paolo Bonzini
2018-01-04  1:59     ` Alan Cox
2018-01-04  2:11       ` Paolo Bonzini
2018-01-04  8:20         ` Woodhouse, David
2018-01-04 11:42           ` Pavel Machek
2018-01-04 11:47             ` Woodhouse, David
2018-01-04 14:20               ` Paolo Bonzini
2018-01-04 14:51                 ` Andrew Cooper
2018-01-04 15:29                   ` Woodhouse, David
2018-01-04 15:32                     ` Paolo Bonzini
2018-01-04 15:37                       ` Andrew Cooper
2018-01-04 16:15                     ` David Woodhouse
2018-01-04 20:00                       ` Tom Lendacky
2018-01-04 20:05                         ` David Woodhouse
2018-01-04 23:47                           ` Tom Lendacky
2018-01-05  0:06                             ` Andrew Cooper
2018-01-05  0:26                             ` Tom Lendacky
2018-01-04 16:52                     ` Andrea Arcangeli
2018-01-04 15:32                   ` Paolo Bonzini
2018-01-04 16:25                     ` Andrea Arcangeli
2018-01-04 17:04                       ` Alan Cox
2018-01-04 17:40                         ` Andrea Arcangeli
2018-01-04 17:13                       ` Dave Hansen
2018-01-04 17:15                         ` Paolo Bonzini
2018-01-04 18:05                           ` Andrea Arcangeli
2018-01-04 14:55                 ` Woodhouse, David
2018-01-04 18:24                 ` Pavel Machek
2018-01-04 19:57           ` Jon Masters
2018-01-05  0:41             ` Jon Masters
2018-01-05  0:54               ` Thomas Gleixner
2018-01-05  4:11                 ` Jon Masters
2018-01-05  9:59                   ` Thomas Gleixner
2018-01-08 10:28                     ` Andrea Arcangeli
2018-01-08 20:42                       ` [tip:x86/pti] x86/tboot: Unbreak tboot with PTI enabled tip-bot for Dave Hansen
2018-01-08 20:53                       ` Avoid speculative indirect calls in kernel Thomas Gleixner
2018-01-08 21:32                         ` Andrea Arcangeli
2018-01-10  0:45                           ` Thomas Gleixner
2018-01-10  1:11                             ` Dave Hansen
2018-01-10 16:02                               ` Thomas Gleixner
2018-01-05  6:49                 ` Willy Tarreau
2018-01-05  6:57                   ` Dave Hansen
2018-01-05  7:13                     ` Willy Tarreau
2018-01-07 14:14                       ` Borislav Petkov
2018-01-07 17:21                         ` David Lang
2018-01-07 18:49                           ` Borislav Petkov
2018-01-07 17:44                         ` Willy Tarreau
2018-01-07 18:55                           ` Borislav Petkov
2018-01-07 22:10                             ` Willy Tarreau
2018-01-08  9:18                               ` Thomas Gleixner
2018-01-08  9:29                                 ` Willy Tarreau
2018-01-08 16:22                               ` Borislav Petkov
2018-01-08 16:53                                 ` Willy Tarreau
2018-01-05 12:12                 ` Alan Cox
2018-01-09  1:44                   ` Samir Bellabes
     [not found]                 ` <CAL9bgJ8XNJgCtxR6+M+Vm9eDBVZ4Dyi_-Lt-Q1ei9N=TE2c6cg@mail.gmail.com>
2018-01-07  5:04                   ` Fwd: " Kiernan Hager
2018-01-07  6:39                     ` Willy Tarreau
2018-01-07 14:01                     ` Alan Cox
2018-01-07 17:47                       ` Willy Tarreau
2018-01-07 18:01                         ` Ivan Ivanov
2018-01-07 18:16                           ` Woodhouse, David
2018-01-04 11:26   ` Pavel Machek
2018-01-04 11:54     ` Alan Cox
2018-01-04 18:33     ` Linus Torvalds
2018-01-04 20:08       ` Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103230934.15788-4-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linuxtronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome