* [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
@ 2017-12-09 16:27 Vincent Legoll
2018-01-05 11:40 ` Daniel Thompson
0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2017-12-09 16:27 UTC (permalink / raw)
To: Andrew Morton, Ingo Molnar, Byungchul Park, Peter Zijlstra,
Paul E. McKenney, Josh Poimboeuf, Geert Uytterhoeven,
Randy Dunlap, Luis R. Rodriguez, Nicholas Piggin,
Thomas Gleixner, linux-kernel
Cc: Vincent Legoll
No need to get into the submenu to disable all related
config entries.
This makes it easier to disable all RUNTIME_TESTS config options
without entering the submenu. It will also enable one to see that
en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
lib/Kconfig.debug | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 947d3e2ed5c2..9436714254b7 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
If unsure, say N.
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+ bool "Runtime Testing"
+
+if RUNTIME_TESTING_MENU
config LKDTM
tristate "Linux Kernel Dump Test Tool Module"
@@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
If unsure, say N.
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
config MEMTEST
bool "Memtest"
--
2.14.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
2017-12-09 16:27 [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all Vincent Legoll
@ 2018-01-05 11:40 ` Daniel Thompson
2018-01-05 12:29 ` Vincent Legoll
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Thompson @ 2018-01-05 11:40 UTC (permalink / raw)
To: Vincent Legoll, Andrew Morton, Ingo Molnar, Byungchul Park,
Peter Zijlstra, Paul E. McKenney, Josh Poimboeuf,
Geert Uytterhoeven, Randy Dunlap, Luis R. Rodriguez,
Nicholas Piggin, Thomas Gleixner, linux-kernel
On 09/12/17 16:27, Vincent Legoll wrote:
> No need to get into the submenu to disable all related
> config entries.
>
> This makes it easier to disable all RUNTIME_TESTS config options
> without entering the submenu. It will also enable one to see that
> en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
Wouldn't you need a "default y" applied to the menuconfig to achieve this?
With this patch applied defconfigs that enable LKDTM by default will no
longer do so (default_defconfig from arch/s390 is an example although
there are others).
Daniel.
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
> lib/Kconfig.debug | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 947d3e2ed5c2..9436714254b7 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
>
> If unsure, say N.
>
> -menu "Runtime Testing"
> +menuconfig RUNTIME_TESTING_MENU
> + bool "Runtime Testing"
> +
> +if RUNTIME_TESTING_MENU
>
> config LKDTM
> tristate "Linux Kernel Dump Test Tool Module"
> @@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
>
> If unsure, say N.
>
> -endmenu # runtime tests
> +endif # RUNTIME_TESTING_MENU
>
> config MEMTEST
> bool "Memtest"
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
2018-01-05 11:40 ` Daniel Thompson
@ 2018-01-05 12:29 ` Vincent Legoll
2018-01-06 17:18 ` [PATCH, v2] " Vincent Legoll
0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2018-01-05 12:29 UTC (permalink / raw)
To: Daniel Thompson
Cc: Andrew Morton, Ingo Molnar, Byungchul Park, Peter Zijlstra,
Paul E. McKenney, Josh Poimboeuf, Geert Uytterhoeven,
Randy Dunlap, Luis R. Rodriguez, Nicholas Piggin,
Thomas Gleixner, Linux Kernel ML
Hello,
On Fri, Jan 5, 2018 at 12:40 PM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> Wouldn't you need a "default y" applied to the menuconfig to achieve this?
>
> With this patch applied defconfigs that enable LKDTM by default will no
> longer do so (default_defconfig from arch/s390 is an example although there
> are others).
Yes, you're right, I'll resend a v2 with the default y added
Thanks
--
Vincent Legoll
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH, v2] make RUNTIME_TESTS a menuconfig to ease disabling it all
2018-01-05 12:29 ` Vincent Legoll
@ 2018-01-06 17:18 ` Vincent Legoll
2018-01-06 17:18 ` [PATCH] " Vincent Legoll
0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2018-01-06 17:18 UTC (permalink / raw)
To: akpm, mingo, byungchul.park, peterz, paulmck, jpoimboe, geert,
rdunlap, mcgrof, npiggin, tglx, linux-kernel
Is this one better ?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
2018-01-06 17:18 ` [PATCH, v2] " Vincent Legoll
@ 2018-01-06 17:18 ` Vincent Legoll
2018-01-06 17:24 ` [PATCH, v2] " Vincent Legoll
0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2018-01-06 17:18 UTC (permalink / raw)
To: akpm, mingo, byungchul.park, peterz, paulmck, jpoimboe, geert,
rdunlap, mcgrof, npiggin, tglx, linux-kernel
Cc: Vincent Legoll
No need to get into the submenu to disable all related
config entries.
This makes it easier to disable all RUNTIME_TESTS config options
without entering the submenu. It will also enable one to see that
en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
v2: added "default y" to avoid breaking existing configs
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
lib/Kconfig.debug | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9d5b78aad4c5..ef6db62a5deb 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1627,7 +1627,10 @@ config DMA_API_DEBUG
If unsure, say N.
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+ bool "Runtime Testing"
+
+if RUNTIME_TESTING_MENU
config LKDTM
tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1918,7 @@ config TEST_DEBUG_VIRTUAL
If unsure, say N.
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
config MEMTEST
bool "Memtest"
--
2.14.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH, v2] make RUNTIME_TESTS a menuconfig to ease disabling it all
2018-01-06 17:18 ` [PATCH] " Vincent Legoll
@ 2018-01-06 17:24 ` Vincent Legoll
2018-01-06 17:24 ` [PATCH] " Vincent Legoll
0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2018-01-06 17:24 UTC (permalink / raw)
To: akpm, mingo, byungchul.park, peterz, paulmck, jpoimboe, geert,
rdunlap, mcgrof, npiggin, tglx, linux-kernel
Argh, sorry for the forgotten "git add", hopefuly this one will be good
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
2018-01-06 17:24 ` [PATCH, v2] " Vincent Legoll
@ 2018-01-06 17:24 ` Vincent Legoll
2018-01-08 4:46 ` Randy Dunlap
0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2018-01-06 17:24 UTC (permalink / raw)
To: akpm, mingo, byungchul.park, peterz, paulmck, jpoimboe, geert,
rdunlap, mcgrof, npiggin, tglx, linux-kernel
Cc: Vincent Legoll
No need to get into the submenu to disable all related
config entries.
This makes it easier to disable all RUNTIME_TESTS config options
without entering the submenu. It will also enable one to see that
en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
v2: added "default y" to avoid breaking existing configs
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
lib/Kconfig.debug | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9d5b78aad4c5..732f7b09ad6f 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1627,7 +1627,11 @@ config DMA_API_DEBUG
If unsure, say N.
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+ bool "Runtime Testing"
+ default y
+
+if RUNTIME_TESTING_MENU
config LKDTM
tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL
If unsure, say N.
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
config MEMTEST
bool "Memtest"
--
2.14.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
2018-01-06 17:24 ` [PATCH] " Vincent Legoll
@ 2018-01-08 4:46 ` Randy Dunlap
0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2018-01-08 4:46 UTC (permalink / raw)
To: Vincent Legoll, akpm, mingo, byungchul.park, peterz, paulmck,
jpoimboe, geert, mcgrof, npiggin, tglx, linux-kernel
On 01/06/18 09:24, Vincent Legoll wrote:
> No need to get into the submenu to disable all related
> config entries.
>
> This makes it easier to disable all RUNTIME_TESTS config options
> without entering the submenu. It will also enable one to see that
> en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> v2: added "default y" to avoid breaking existing configs
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Acked-and-tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> lib/Kconfig.debug | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9d5b78aad4c5..732f7b09ad6f 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1627,7 +1627,11 @@ config DMA_API_DEBUG
>
> If unsure, say N.
>
> -menu "Runtime Testing"
> +menuconfig RUNTIME_TESTING_MENU
> + bool "Runtime Testing"
> + default y
> +
> +if RUNTIME_TESTING_MENU
>
> config LKDTM
> tristate "Linux Kernel Dump Test Tool Module"
> @@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL
>
> If unsure, say N.
>
> -endmenu # runtime tests
> +endif # RUNTIME_TESTING_MENU
>
> config MEMTEST
> bool "Memtest"
>
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-01-08 4:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-09 16:27 [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all Vincent Legoll
2018-01-05 11:40 ` Daniel Thompson
2018-01-05 12:29 ` Vincent Legoll
2018-01-06 17:18 ` [PATCH, v2] " Vincent Legoll
2018-01-06 17:18 ` [PATCH] " Vincent Legoll
2018-01-06 17:24 ` [PATCH, v2] " Vincent Legoll
2018-01-06 17:24 ` [PATCH] " Vincent Legoll
2018-01-08 4:46 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®