mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Jiri Kosina <jikos@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linux-foundation.org>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Kees Cook <keescook@google.com>,
	Andy Lutomirski <luto@amacapital.net>,
	gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives
Date: Thu, 11 Jan 2018 18:23:03 +0100	[thread overview]
Message-ID: <20180111172303.GI6176@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1515691163.22302.382.camel@infradead.org>

On Thu, Jan 11, 2018 at 05:19:23PM +0000, David Woodhouse wrote:
> On Thu, 2018-01-11 at 18:05 +0100, Peter Zijlstra wrote:
> > On Thu, Jan 11, 2018 at 06:01:23PM +0100, Jiri Kosina wrote:
> > > On Thu, 11 Jan 2018, Josh Poimboeuf wrote:
> > > 
> > > > I think I heard that retpolines won't be ported to anything older than 
> > > > GCC 4.9, so maybe it's safe to use '%='.  I don't remember when it was 
> > > > introduced into GCC though.
> > > 
> > > I'm afraid we'll have to backport retpolines in some form to 4.3.x at 
> > > least. I'd be surprised if we'd be the only ones on this planet :)
> > 
> > So upstream code is going to require 4.5 at least, and 4.4 has %=.
> > Backport effort will just have to cope or backport more GCC bits, that
> > is, if you're backporting retpoline to 4.3 also backport asm-goto.
> 
> Again, the RSB thing is for more than just retpoline; it's needed for
> IBRS support too and that *doesn't* necessarily require a newer
> compiler at all.

I think the asm-goto was exactly for IBRS, because without that you get
to sprinkle LFENCE all over the place.

  reply	other threads:[~2018-01-11 17:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  1:48 [PATCH 0/3] objtool: retpoline compatibility Josh Poimboeuf
2018-01-11  1:48 ` [PATCH 1/3] objtool: Detect jumps to retpoline thunks Josh Poimboeuf
2018-01-11  1:48 ` [PATCH 2/3] objtool: Ignore retpoline alternatives Josh Poimboeuf
2018-01-11 16:27   ` David Woodhouse
2018-01-11 16:33     ` Josh Poimboeuf
2018-01-11 16:39       ` David Woodhouse
2018-01-11 16:48         ` Josh Poimboeuf
2018-01-11 16:55           ` David Woodhouse
2018-01-11 17:25             ` Josh Poimboeuf
2018-01-11 16:58           ` Peter Zijlstra
2018-01-11 17:05             ` Jiri Kosina
2018-01-11 17:01           ` Jiri Kosina
2018-01-11 17:05             ` Peter Zijlstra
2018-01-11 17:19               ` David Woodhouse
2018-01-11 17:23                 ` Peter Zijlstra [this message]
2018-01-11 16:44       ` Peter Zijlstra
2018-01-11 17:29     ` Linus Torvalds
2018-01-11 17:37       ` Josh Poimboeuf
2018-01-11 17:43       ` David Woodhouse
2018-01-11 17:56       ` Peter Zijlstra
2018-01-12 20:36         ` Ingo Molnar
2018-01-11 17:57       ` David Woodhouse
2018-01-11  1:48 ` [PATCH 3/3] Revert "x86/retpoline: Temporarily disable objtool when CONFIG_RETPOLINE=y" Josh Poimboeuf
2018-01-11 10:22 ` [PATCH 0/3] objtool: retpoline compatibility David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111172303.GI6176@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linux-foundation.org \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=pjt@google.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome