From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
Greg Kroah-Hartman <gregkh@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Kees Cook <keescook@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>,
Jiri Kosina <jikos@kernel.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives
Date: Thu, 11 Jan 2018 11:37:44 -0600 [thread overview]
Message-ID: <20180111173744.2iysfjky7hbjozqf@treble> (raw)
In-Reply-To: <CA+55aFzLA2dBhVTsvEBZ58aS2Jgp020cPC3MvMR_RuJqFmM67Q@mail.gmail.com>
On Thu, Jan 11, 2018 at 09:29:48AM -0800, Linus Torvalds wrote:
> That, btw, is also why it's pointless to make the small numbers
> "bigger". Using "1122" as a label is actively worse than just using
> "1".
>
> You shouldn't try to fool yourself and think that your number is
> "unique". It doesn't need to be. A label needs to be unique within one
> use, and the use just tells _which_ of the non-unique numbers you use.
>
> And yes, you could even re-use the number within one macro or inline
> asm. But that's just confusing. Make the number unique for the
> particular macro or inline use.
What if the macro is used by another macro which needs to jump across
it? If the labels conflict then the outer macro will accidentally jump
to the inner macro.
--
Josh
next prev parent reply other threads:[~2018-01-11 17:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 1:48 [PATCH 0/3] objtool: retpoline compatibility Josh Poimboeuf
2018-01-11 1:48 ` [PATCH 1/3] objtool: Detect jumps to retpoline thunks Josh Poimboeuf
2018-01-11 1:48 ` [PATCH 2/3] objtool: Ignore retpoline alternatives Josh Poimboeuf
2018-01-11 16:27 ` David Woodhouse
2018-01-11 16:33 ` Josh Poimboeuf
2018-01-11 16:39 ` David Woodhouse
2018-01-11 16:48 ` Josh Poimboeuf
2018-01-11 16:55 ` David Woodhouse
2018-01-11 17:25 ` Josh Poimboeuf
2018-01-11 16:58 ` Peter Zijlstra
2018-01-11 17:05 ` Jiri Kosina
2018-01-11 17:01 ` Jiri Kosina
2018-01-11 17:05 ` Peter Zijlstra
2018-01-11 17:19 ` David Woodhouse
2018-01-11 17:23 ` Peter Zijlstra
2018-01-11 16:44 ` Peter Zijlstra
2018-01-11 17:29 ` Linus Torvalds
2018-01-11 17:37 ` Josh Poimboeuf [this message]
2018-01-11 17:43 ` David Woodhouse
2018-01-11 17:56 ` Peter Zijlstra
2018-01-12 20:36 ` Ingo Molnar
2018-01-11 17:57 ` David Woodhouse
2018-01-11 1:48 ` [PATCH 3/3] Revert "x86/retpoline: Temporarily disable objtool when CONFIG_RETPOLINE=y" Josh Poimboeuf
2018-01-11 10:22 ` [PATCH 0/3] objtool: retpoline compatibility David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111173744.2iysfjky7hbjozqf@treble \
--to=jpoimboe@redhat.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®