From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Kees Cook <keescook@google.com>,
Andy Lutomirski <luto@amacapital.net>,
Jiri Kosina <jikos@kernel.org>,
gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives
Date: Thu, 11 Jan 2018 17:44:24 +0100 [thread overview]
Message-ID: <20180111164424.GN3040@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180111163326.deqtbqt72avfweup@treble>
On Thu, Jan 11, 2018 at 10:33:26AM -0600, Josh Poimboeuf wrote:
> On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote:
> > On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote:
> > >
> > > +#define ANNOTATE_NOSPEC_ALTERNATIVE \
> > > + "999:\n\t" \
> > > + ".pushsection .discard.nospec\n\t" \
> > > + ".long 999b - .\n\t" \
> > > + ".popsection\n\t"
> > > +
> >
> > <mode name="peterz">
> > Ick, numbers. Use .Lfoo_%= instead.
> > </mode>
>
> I seem to recall that not working with inline asm, maybe old versions of
> GCC don't like it or something? I can try it and see if 0-day bot
> complains.
Note that we'll raise the GCC limit to 4.5 soon to mandate asm-goto, for
x86 at least.
next prev parent reply other threads:[~2018-01-11 16:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 1:48 [PATCH 0/3] objtool: retpoline compatibility Josh Poimboeuf
2018-01-11 1:48 ` [PATCH 1/3] objtool: Detect jumps to retpoline thunks Josh Poimboeuf
2018-01-11 1:48 ` [PATCH 2/3] objtool: Ignore retpoline alternatives Josh Poimboeuf
2018-01-11 16:27 ` David Woodhouse
2018-01-11 16:33 ` Josh Poimboeuf
2018-01-11 16:39 ` David Woodhouse
2018-01-11 16:48 ` Josh Poimboeuf
2018-01-11 16:55 ` David Woodhouse
2018-01-11 17:25 ` Josh Poimboeuf
2018-01-11 16:58 ` Peter Zijlstra
2018-01-11 17:05 ` Jiri Kosina
2018-01-11 17:01 ` Jiri Kosina
2018-01-11 17:05 ` Peter Zijlstra
2018-01-11 17:19 ` David Woodhouse
2018-01-11 17:23 ` Peter Zijlstra
2018-01-11 16:44 ` Peter Zijlstra [this message]
2018-01-11 17:29 ` Linus Torvalds
2018-01-11 17:37 ` Josh Poimboeuf
2018-01-11 17:43 ` David Woodhouse
2018-01-11 17:56 ` Peter Zijlstra
2018-01-12 20:36 ` Ingo Molnar
2018-01-11 17:57 ` David Woodhouse
2018-01-11 1:48 ` [PATCH 3/3] Revert "x86/retpoline: Temporarily disable objtool when CONFIG_RETPOLINE=y" Josh Poimboeuf
2018-01-11 10:22 ` [PATCH 0/3] objtool: retpoline compatibility David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111164424.GN3040@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome