mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	tglx@linutronix.de, dwmw@amazon.co.uk,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	arjan.van.de.ven@intel.com, peterz@infradead.org,
	Andi Kleen <ak@linux.intel.com>,
	jeyu@kernel.org
Subject: Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module
Date: Sat, 13 Jan 2018 06:53:00 -0800	[thread overview]
Message-ID: <20180113145259.ofw2u656h4awdyzw@two.firstfloor.org> (raw)
In-Reply-To: <20180113141209.GA13015@kroah.com>

> > When the a module hasn't been compiled with a retpoline
> > aware compiler, print a warning and set a taint flag.
> 
> Isn't that caught by the "build with a different compiler/version" check
> that we have?  Or used to have?  If not, can't we just make it into that

- the compiler version number may not change if a distribution backports
the gcc changes for the new flag
- the module might be using a custom make file that does not correctly
set the flag, even if the compiler supports it

> type of check to catch this type of problem no matter what type of
> feature/option it is trying to catch?

I suspect that would be far more complicated. Also what's the point
of putting this information into every symbol? Once per module 
is good enough.

We already have similar checks for staging etc.

-Andi

  parent reply	other threads:[~2018-01-13 14:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 17:55 Andi Kleen
2018-01-12 19:01 ` David Woodhouse
2018-01-12 19:17   ` Andi Kleen
2018-01-13 14:12 ` Greg KH
2018-01-13 14:38   ` Van De Ven, Arjan
2018-01-13 15:37     ` Greg KH
2018-01-13 14:53   ` Andi Kleen [this message]
2018-01-13 15:36     ` Greg KH
2018-01-13 18:20       ` Andi Kleen
2018-01-16 20:08       ` Andi Kleen
2018-01-15 12:47 ` David Laight
2018-01-15 12:53   ` Van De Ven, Arjan
2018-01-15 13:01     ` David Woodhouse
2018-01-15 14:08       ` David Laight
2018-01-15 16:48   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180113145259.ofw2u656h4awdyzw@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=arjan.van.de.ven@intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®