mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Andi Kleen' <andi@firstfloor.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"arjan.van.de.ven@intel.com" <arjan.van.de.ven@intel.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	Andi Kleen <ak@linux.intel.com>,
	"jeyu@kernel.org" <jeyu@kernel.org>
Subject: RE: [PATCH] retpoline/module: Taint kernel for missing retpoline in module
Date: Mon, 15 Jan 2018 12:47:48 +0000	[thread overview]
Message-ID: <a8ff2d96e82248ee97068459a8bd903b@AcuMS.aculab.com> (raw)
In-Reply-To: <20180112175507.31750-1-andi@firstfloor.org>

From: Andi Kleen
> Sent: 12 January 2018 17:55
> 
> There's a risk that a kernel that has full retpoline mitigations
> becomes vulnerable when a module gets loaded that hasn't been
> compiled with the right compiler or the right option.
> 
> We cannot fix it, but should at least warn the user when that
> happens.
> 
> Add a flag to each module if it has been compiled with RETPOLINE
> 
> When the a module hasn't been compiled with a retpoline
> aware compiler, print a warning and set a taint flag.
> 
> For modules it is checked at compile time, however it cannot
> check assembler or other non compiled objects used in the module link.

It is not unlikely that most of a module's code is released as a
binary 'blob', with only the part that needs to match the kernel ABI
compiled on the target system.
(This allows a single binary driver be loaded onto different Linux
kernel versions.)
Such code is unlikely to be compiled with the latest compiler.
Indeed, doing so may stop the module loading on old kernels.

	David

  parent reply	other threads:[~2018-01-15 12:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 17:55 Andi Kleen
2018-01-12 19:01 ` David Woodhouse
2018-01-12 19:17   ` Andi Kleen
2018-01-13 14:12 ` Greg KH
2018-01-13 14:38   ` Van De Ven, Arjan
2018-01-13 15:37     ` Greg KH
2018-01-13 14:53   ` Andi Kleen
2018-01-13 15:36     ` Greg KH
2018-01-13 18:20       ` Andi Kleen
2018-01-16 20:08       ` Andi Kleen
2018-01-15 12:47 ` David Laight [this message]
2018-01-15 12:53   ` Van De Ven, Arjan
2018-01-15 13:01     ` David Woodhouse
2018-01-15 14:08       ` David Laight
2018-01-15 16:48   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8ff2d96e82248ee97068459a8bd903b@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=arjan.van.de.ven@intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome