[PATCH] spi: sprd: Use 'spi_master_put()' instead of 'spi_controller_put()'

[PATCH] spi: sprd: Use 'spi_master_put()' instead of 'spi_controller_put()'

[Christophe JAILLET]

'spi_alloc_master()' calls should be balanced by a 'spi_master_put()' call.

'spi_controller_put()' is equivalent (see include/linux/spi/spi.h) but it
is cleaner and more logical to use 'spi_master_put()'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/spi/spi-sprd-adi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c
index 5993bdbf79e4..55b9aada467e 100644
--- a/drivers/spi/spi-sprd-adi.c
+++ b/drivers/spi/spi-sprd-adi.c
@@ -382,7 +382,7 @@ static int sprd_adi_probe(struct platform_device *pdev)
 free_hwlock:
 	hwspin_lock_free(sadi->hwlock);
 put_ctlr:
-	spi_controller_put(ctlr);
+	spi_master_put(ctlr);
 	return ret;
 }
 
-- 
2.14.1


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

Re: [PATCH] spi: sprd: Use 'spi_master_put()' instead of 'spi_controller_put()'

[Geert Uytterhoeven]

Hi Christophe,

On Fri, Jan 26, 2018 at 4:52 PM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> 'spi_alloc_master()' calls should be balanced by a 'spi_master_put()' call.
>
> 'spi_controller_put()' is equivalent (see include/linux/spi/spi.h) but it
> is cleaner and more logical to use 'spi_master_put()'.

My intention was to phase out the spi_master_* names, and remove them
when there are no users left.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] spi: sprd: Use 'spi_master_put()' instead of 'spi_controller_put()'

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Fri, Jan 26, 2018 at 05:16:34PM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 26, 2018 at 4:52 PM, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> > 'spi_alloc_master()' calls should be balanced by a 'spi_master_put()' call.

> > 'spi_controller_put()' is equivalent (see include/linux/spi/spi.h) but it
> > is cleaner and more logical to use 'spi_master_put()'.

> My intention was to phase out the spi_master_* names, and remove them
> when there are no users left.

Yeah, a better change here would be adding the matching allocation
function and using that.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]