* [PATCH] ARC: Don't check presense of Timer1 in SMP builds
@ 2018-02-13 19:35 Alexey Brodkin
2018-02-13 19:53 ` Vineet Gupta
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Brodkin @ 2018-02-13 19:35 UTC (permalink / raw)
To: linux-snps-arc; +Cc: linux-kernel, Vineet Gupta, Alexey Brodkin
In case of SMP we use GFRC from ARconnect and Timer1 is left
untouched. Still with that check in place we're panicing if Timer1
is missing in current hardware which is quite unexpected.
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---
arch/arc/kernel/setup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
index cf97f7d88934..1142d76a7e8f 100644
--- a/arch/arc/kernel/setup.c
+++ b/arch/arc/kernel/setup.c
@@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
if (!cpu->extn.timer0)
panic("Timer0 is not present!\n");
+#ifndef CONFIG_SMP
if (!cpu->extn.timer1)
panic("Timer1 is not present!\n");
+#endif
#ifdef CONFIG_ARC_HAS_DCCM
/*
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARC: Don't check presense of Timer1 in SMP builds
2018-02-13 19:35 [PATCH] ARC: Don't check presense of Timer1 in SMP builds Alexey Brodkin
@ 2018-02-13 19:53 ` Vineet Gupta
0 siblings, 0 replies; 2+ messages in thread
From: Vineet Gupta @ 2018-02-13 19:53 UTC (permalink / raw)
To: Alexey Brodkin, linux-snps-arc; +Cc: linux-kernel
On 02/13/2018 11:35 AM, Alexey Brodkin wrote:
> In case of SMP we use GFRC from ARconnect and Timer1 is left
> untouched. Still with that check in place we're panicing if Timer1
> is missing in current hardware which is quite unexpected.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
> arch/arc/kernel/setup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index cf97f7d88934..1142d76a7e8f 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
> if (!cpu->extn.timer0)
> panic("Timer0 is not present!\n");
>
> +#ifndef CONFIG_SMP
> if (!cpu->extn.timer1)
> panic("Timer1 is not present!\n");
> +#endif
Curious, you have a config w/o TIMER1, so is this a fallout of recent discussions !
-Vineet
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-13 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-13 19:35 [PATCH] ARC: Don't check presense of Timer1 in SMP builds Alexey Brodkin
2018-02-13 19:53 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®