From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org, ebiederm@xmission.com
Cc: mingo@kernel.org, tglx@linutronix.de, x86@kernel.org,
douly.fnst@cn.fujitsu.com, joro@8bytes.org, uobergfe@redhat.com,
prarit@redhat.com, Baoquan He <bhe@redhat.com>
Subject: [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump
Date: Wed, 14 Feb 2018 13:46:50 +0800 [thread overview]
Message-ID: <20180214054656.3780-1-bhe@redhat.com> (raw)
This is v5 post. Newly added patch 0002 includes the change
related to KEXEC_JUMP path. Patch 0003 only includes the
regression fix.
A regression bug was introduced in below commit.
commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
It caused the action to fail that we try to restore boot irq mode
in reboot and kexec/kdump. Details can be seen in patch 0003.
Warning can always be seen during kdump kernel boot on qemu/kvm
platform. Our customer even saw casual kdump kernel hang once in
~30 attempts during stress testing of kdump on KVM machine.
v4->v5:
Take out the change related to KEXEC_JUMP to a new patch 0002
according to Eric's suggestion.
Patch 0003 in this series only includes the regression fix.
v3->v4:
Eric pointed out that in patch 0002 the change related to
KEXEC_JUMP is not right.
Correct it.
Add Fixes tag and Cc to stable.
v2->v3:
Change as Eric suggested:
Rerrange patches and change code and messy function/variable naming.
Change patch subject and log to make it more understandable.
*** BLURB HERE ***
Baoquan He (6):
x86/apic: Split out restore_boot_irq_mode from disable_IO_APIC
x86/apic: Replace disable_IO_APIC for KEXEC_JUMP
x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump
x86/apic: Remove useless disable_IO_APIC
x86/apic: Rename variable/function related to x86_io_apic_ops
x86/apic: Set up through-local-APIC on boot CPU if 'noapic' specified
arch/x86/include/asm/io_apic.h | 9 +++++----
arch/x86/include/asm/x86_init.h | 8 ++++----
arch/x86/kernel/apic/apic.c | 2 +-
arch/x86/kernel/apic/io_apic.c | 16 ++++------------
arch/x86/kernel/crash.c | 3 ++-
arch/x86/kernel/machine_kexec_32.c | 8 ++++----
arch/x86/kernel/machine_kexec_64.c | 8 ++++----
arch/x86/kernel/reboot.c | 3 ++-
arch/x86/kernel/x86_init.c | 6 +++---
arch/x86/xen/apic.c | 2 +-
drivers/iommu/irq_remapping.c | 4 ++--
11 files changed, 32 insertions(+), 37 deletions(-)
--
2.13.6
next reply other threads:[~2018-02-14 5:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 5:46 Baoquan He [this message]
2018-02-14 5:46 ` [PATCH v5 1/6] x86/apic: Split out restore_boot_irq_mode from disable_IO_APIC Baoquan He
2018-02-17 11:41 ` [tip:x86/apic] x86/apic: Split out restore_boot_irq_mode() from disable_IO_APIC() tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 2/6] x86/apic: Replace disable_IO_APIC for KEXEC_JUMP Baoquan He
2018-02-17 11:41 ` [tip:x86/apic] x86/apic: Split disable_IO_APIC() into two functions to fix CONFIG_KEXEC_JUMP=y tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 3/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Baoquan He
2018-02-17 11:42 ` [tip:x86/apic] x86/apic: Fix restoring boot IRQ " tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 4/6] x86/apic: Remove useless disable_IO_APIC Baoquan He
2018-02-17 11:42 ` [tip:x86/apic] x86/apic: Remove the (now) unused disable_IO_APIC() function tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 5/6] x86/apic: Rename variable/function related to x86_io_apic_ops Baoquan He
2018-02-17 11:43 ` [tip:x86/apic] x86/apic: Rename variables and functions " tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 6/6] x86/apic: Set up through-local-APIC on boot CPU if 'noapic' specified Baoquan He
2018-02-17 11:43 ` [tip:x86/apic] x86/apic: Set up through-local-APIC mode on the " tip-bot for Baoquan He
2018-02-16 9:38 ` [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Ingo Molnar
2018-02-16 10:24 ` Baoquan He
2018-02-17 10:46 ` Ingo Molnar
2018-02-17 11:28 ` Baoquan He
2018-02-16 19:16 ` Eric W. Biederman
2018-02-17 10:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214054656.3780-1-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=uobergfe@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome