[PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

[PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

[Yash Omer]

This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.

Signed-off-by: Yash Omer <yashomer0007@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 5be1af20d2d4..974a7572fafc 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
 			goto exit;
 		}
 		/* ibss options */
-		result = hfa384x_drvr_setconfig16(hw,
-					HFA384x_RID_CREATEIBSS,
+		result = hfa384x_drvr_setconfig16
+					(hw, HFA384x_RID_CREATEIBSS,
 					HFA384x_CREATEIBSS_JOINCREATEIBSS);
 		if (result) {
 			netdev_err(wlandev->netdev,
-- 
2.14.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

[Greg KH]

On Fri, Feb 16, 2018 at 12:18:36AM +0530, Yash Omer wrote:
> This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.
> 
> Signed-off-by: Yash Omer <yashomer0007@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 5be1af20d2d4..974a7572fafc 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
>  			goto exit;
>  		}
>  		/* ibss options */
> -		result = hfa384x_drvr_setconfig16(hw,
> -					HFA384x_RID_CREATEIBSS,
> +		result = hfa384x_drvr_setconfig16
> +					(hw, HFA384x_RID_CREATEIBSS,

The original code is just fine, why is checkpatch complaining about
this?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

[Joe Perches]

On Fri, 2018-02-16 at 15:36 +0100, Greg KH wrote:
> On Fri, Feb 16, 2018 at 12:18:36AM +0530, Yash Omer wrote:
> > This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.
[]
> > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
[]
> > @@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
> >  			goto exit;
> >  		}
> >  		/* ibss options */
> > -		result = hfa384x_drvr_setconfig16(hw,
> > -					HFA384x_RID_CREATEIBSS,
> > +		result = hfa384x_drvr_setconfig16
> > +					(hw, HFA384x_RID_CREATEIBSS,
> 
> The original code is just fine, why is checkpatch complaining about
> this?

lack of argument alignment to parentheses.

Maybe wlan-ng should be marked obsolete in MAINTAINERS.