From: Joe Lawrence <joe.lawrence@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/livepatch: introduce tests
Date: Sun, 8 Apr 2018 11:42:31 -0400 [thread overview]
Message-ID: <20180408154231.ihnglqyya5nric4q@redhat.com> (raw)
In-Reply-To: <20180407023646.k3gjrgjwzhwgu6fq@treble>
On Fri, Apr 06, 2018 at 09:36:46PM -0500, Josh Poimboeuf wrote:
> On Wed, Mar 28, 2018 at 03:49:48PM -0400, Joe Lawrence wrote:
> > Add a few livepatch modules and simple target modules that the included
> > regression suite can run tests against.
> >
> > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> > ---
> > lib/Kconfig.debug | 12 +
> > lib/Makefile | 2 +
> > lib/livepatch/Makefile | 18 +
> > lib/livepatch/test_klp_atomic_replace.c | 69 +++
> > lib/livepatch/test_klp_callbacks_busy.c | 43 ++
> > lib/livepatch/test_klp_callbacks_demo.c | 132 ++++++
> > lib/livepatch/test_klp_callbacks_demo2.c | 104 ++++
> > lib/livepatch/test_klp_callbacks_mod.c | 24 +
> > lib/livepatch/test_klp_livepatch.c | 62 +++
> > tools/testing/selftests/Makefile | 1 +
> > tools/testing/selftests/livepatch/Makefile | 8 +
> > tools/testing/selftests/livepatch/config | 1 +
> > tools/testing/selftests/livepatch/functions.sh | 202 ++++++++
> > .../testing/selftests/livepatch/test-callbacks.sh | 526 +++++++++++++++++++++
> > .../testing/selftests/livepatch/test-livepatch.sh | 177 +++++++
> > .../selftests/livepatch/test-shadow-vars.sh | 13 +
> > 16 files changed, 1394 insertions(+)
> > create mode 100644 lib/livepatch/Makefile
> > create mode 100644 lib/livepatch/test_klp_atomic_replace.c
> > create mode 100644 lib/livepatch/test_klp_callbacks_busy.c
> > create mode 100644 lib/livepatch/test_klp_callbacks_demo.c
> > create mode 100644 lib/livepatch/test_klp_callbacks_demo2.c
> > create mode 100644 lib/livepatch/test_klp_callbacks_mod.c
> > create mode 100644 lib/livepatch/test_klp_livepatch.c
> > create mode 100644 tools/testing/selftests/livepatch/Makefile
> > create mode 100644 tools/testing/selftests/livepatch/config
> > create mode 100644 tools/testing/selftests/livepatch/functions.sh
> > create mode 100755 tools/testing/selftests/livepatch/test-callbacks.sh
> > create mode 100755 tools/testing/selftests/livepatch/test-livepatch.sh
> > create mode 100755 tools/testing/selftests/livepatch/test-shadow-vars.sh
>
> I love this. Nice work!
>
> As you and Petr discussed, it would be nice to get rid of some of the
> delays, and also the callback tests will be very important.
I've got v2 WIP that minimizes the delays, cleans up build flags, and
adds a basic shadow variable test.
Since these tests are based on top of Petr's current patchsets for
atomic replace and shadow variables, it probably makes sense for those
to merge first. I can post test results to his patchsets if that helps.
These tests are basically a mash up of some of the tedious callback
Documentation and shadow variable sample livepatches. Since there will
be a lot of duplication, should we just remove redundant doc/samples in
favor of these tests?
-- Joe
next prev parent reply other threads:[~2018-04-08 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 19:49 [PATCH] Add livepatch kselftests Joe Lawrence
2018-03-28 19:49 ` [PATCH] selftests/livepatch: introduce tests Joe Lawrence
2018-03-29 20:42 ` kbuild test robot
2018-04-07 2:36 ` Josh Poimboeuf
2018-04-08 15:42 ` Joe Lawrence [this message]
2018-04-09 14:05 ` Petr Mladek
2018-04-10 14:31 ` Miroslav Benes
2018-04-10 17:51 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408154231.ihnglqyya5nric4q@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®