mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	lpechacek@suse.com, nstange@suse.de
Subject: Re: [PATCH] selftests/livepatch: introduce tests
Date: Tue, 10 Apr 2018 12:51:05 -0500	[thread overview]
Message-ID: <20180410175105.eghfnktjq55vaxto@treble> (raw)
In-Reply-To: <alpine.LSU.2.21.1804101625090.8026@pobox.suse.cz>

On Tue, Apr 10, 2018 at 04:31:05PM +0200, Miroslav Benes wrote:
> 
> > > > I love this.  Nice work!
> 
> Yes, it looks really good.
> 
> > > > As you and Petr discussed, it would be nice to get rid of some of the
> > > > delays, and also the callback tests will be very important.
> > > 
> > > I've got v2 WIP that minimizes the delays, cleans up build flags, and
> > > adds a basic shadow variable test.
> > 
> > Sounds great.
> > 
> > > Since these tests are based on top of Petr's current patchsets for
> > > atomic replace and shadow variables, it probably makes sense for those
> > > to merge first.  I can post test results to his patchsets if that helps.
> > 
> > Sounds good to me. We could synchronize the merge. But I think that it
> > will not be a big deal if we would merge the atomic replace slightly
> > earlier if the tests needed some more love.
> 
> Well, it depends. Josh wants the patch first and then atomic replace. So 
> we can merge selftests for all features we currently have and tests for 
> atomic replace could go with it.

Well, I don't want to add additional work, if it's not needed.  Joe's
selftests are coming along nicely.  If the selftest patch is merged
shortly after Petr's set, that's fine with me.  Or maybe Petr can just
add Joe's patch to the end of his set.

-- 
Josh

      reply	other threads:[~2018-04-10 17:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 19:49 [PATCH] Add livepatch kselftests Joe Lawrence
2018-03-28 19:49 ` [PATCH] selftests/livepatch: introduce tests Joe Lawrence
2018-03-29 20:42   ` kbuild test robot
2018-04-07  2:36   ` Josh Poimboeuf
2018-04-08 15:42     ` Joe Lawrence
2018-04-09 14:05       ` Petr Mladek
2018-04-10 14:31         ` Miroslav Benes
2018-04-10 17:51           ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410175105.eghfnktjq55vaxto@treble \
    --to=jpoimboe@redhat.com \
    --cc=joe.lawrence@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=lpechacek@suse.com \
    --cc=mbenes@suse.cz \
    --cc=nstange@suse.de \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®