From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: lee.jones@linaro.org
Cc: groeck@chromium.org, andy.shevchenko@gmail.com,
kernel@collabora.com, gwendal@chromium.org,
linux-kernel@vger.kernel.org,
Vincent Palatin <vpalatin@chromium.org>
Subject: [RESEND PATCH v5 1/7] mfd: cros_ec: fail early if we cannot identify the EC
Date: Wed, 18 Apr 2018 12:23:58 +0200 [thread overview]
Message-ID: <20180418102405.17790-2-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180418102405.17790-1-enric.balletbo@collabora.com>
From: Vincent Palatin <vpalatin@chromium.org>
If we cannot communicate with the EC chip to detect the protocol version
and its features, it's very likely useless to continue. Else we will
commit all kind of uninformed mistakes (using the wrong protocol, the
wrong buffer size, mixing the EC with other chips).
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Acked-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/mfd/cros_ec.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index d61024141e2b..74780f2964a1 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
mutex_init(&ec_dev->lock);
- cros_ec_query_all(ec_dev);
+ err = cros_ec_query_all(ec_dev);
+ if (err) {
+ dev_err(dev, "Cannot identify the EC: error %d\n", err);
+ return err;
+ }
if (ec_dev->irq) {
err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread,
--
2.17.0
next prev parent reply other threads:[~2018-04-18 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 10:23 [RESEND PATCH v5 0/7] mfd: cros_ec: add subdevices and fixes Enric Balletbo i Serra
2018-04-18 10:23 ` Enric Balletbo i Serra [this message]
2018-04-18 10:23 ` [RESEND PATCH v5 2/7] mfd: cros_ec: free IRQ automatically Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 3/7] mfd: cros_ec: Don't try to grab log when suspended Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 4/7] mfd: cros_ec_dev: Register cros-ec-rtc driver as a subdevice Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 5/7] mfd: cros_ec_dev: register shutdown function for debugfs Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 6/7] mfd: cros_ec_i2c: add ACPI module device table Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 7/7] mfd: cros_ec_i2c: moving the system sleep pm ops to late Enric Balletbo i Serra
2018-05-18 13:45 ` [RESEND PATCH v5 0/7] mfd: cros_ec: add subdevices and fixes Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418102405.17790-2-enric.balletbo@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®