mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: lee.jones@linaro.org
Cc: groeck@chromium.org, andy.shevchenko@gmail.com,
	kernel@collabora.com, gwendal@chromium.org,
	linux-kernel@vger.kernel.org, Daniel Hung-yu Wu <hywu@google.com>,
	Daniel Hung-yu Wu <hywu@chromium.org>
Subject: [RESEND PATCH v5 5/7] mfd: cros_ec_dev: register shutdown function for debugfs
Date: Wed, 18 Apr 2018 12:24:02 +0200	[thread overview]
Message-ID: <20180418102405.17790-6-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180418102405.17790-1-enric.balletbo@collabora.com>

From: Daniel Hung-yu Wu <hywu@google.com>

Reboot or shutdown during delayed works could corrupt communication with
EC and certain I2C controller may not be able to recover from the error
state.

This patch registers a shutdown callback used to cancel the debugfs log
worker thread.

Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---

Changes in v5: None
Changes in v4:
- [6/8] Add Acked-by Lee Jones.

Changes in v3:
- [6/8] Add the Reviewed-by Andy Shevchenko.

Changes in v2:
- [6/8] This patch is new in this series.

 drivers/mfd/cros_ec_dev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index a393b3c11aa0..1f889523885d 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -472,6 +472,14 @@ static int ec_device_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static void ec_device_shutdown(struct platform_device *pdev)
+{
+	struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
+
+	/* Be sure to clear up debugfs delayed works */
+	cros_ec_debugfs_remove(ec);
+}
+
 static const struct platform_device_id cros_ec_id[] = {
 	{ DRV_NAME, 0 },
 	{ /* sentinel */ },
@@ -514,6 +522,7 @@ static struct platform_driver cros_ec_dev_driver = {
 	},
 	.probe = ec_device_probe,
 	.remove = ec_device_remove,
+	.shutdown = ec_device_shutdown,
 };
 
 static int __init cros_ec_dev_init(void)
-- 
2.17.0

  parent reply	other threads:[~2018-04-18 10:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 10:23 [RESEND PATCH v5 0/7] mfd: cros_ec: add subdevices and fixes Enric Balletbo i Serra
2018-04-18 10:23 ` [RESEND PATCH v5 1/7] mfd: cros_ec: fail early if we cannot identify the EC Enric Balletbo i Serra
2018-04-18 10:23 ` [RESEND PATCH v5 2/7] mfd: cros_ec: free IRQ automatically Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 3/7] mfd: cros_ec: Don't try to grab log when suspended Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 4/7] mfd: cros_ec_dev: Register cros-ec-rtc driver as a subdevice Enric Balletbo i Serra
2018-04-18 10:24 ` Enric Balletbo i Serra [this message]
2018-04-18 10:24 ` [RESEND PATCH v5 6/7] mfd: cros_ec_i2c: add ACPI module device table Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 7/7] mfd: cros_ec_i2c: moving the system sleep pm ops to late Enric Balletbo i Serra
2018-05-18 13:45 ` [RESEND PATCH v5 0/7] mfd: cros_ec: add subdevices and fixes Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418102405.17790-6-enric.balletbo@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=hywu@chromium.org \
    --cc=hywu@google.com \
    --cc=kernel@collabora.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®