From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: lee.jones@linaro.org
Cc: groeck@chromium.org, andy.shevchenko@gmail.com,
kernel@collabora.com, gwendal@chromium.org,
linux-kernel@vger.kernel.org
Subject: [RESEND PATCH v5 4/7] mfd: cros_ec_dev: Register cros-ec-rtc driver as a subdevice.
Date: Wed, 18 Apr 2018 12:24:01 +0200 [thread overview]
Message-ID: <20180418102405.17790-5-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180418102405.17790-1-enric.balletbo@collabora.com>
Check whether this EC instance has RTC host command support and instatiate
the RTC driver as a subdevice in such case.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
Changes in v5:
- [4/8] For mfd_cell struct use one line and no need for the comma.
Changes in v4:
- [4/8] Nit: check -> Check (Lee Jones)
- [4/8] Use ARRAY_SIZE() instead of hardcoded number (Lee Jones)
Changes in v3:
- [4/8] Add the Reviewed-by Andy Shevchenko.
Changes in v2:
- [4/8] Add the Reviewed-by Gwendal.
drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 5a7d4e1dea70..a393b3c11aa0 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -383,6 +383,10 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec)
kfree(msg);
}
+static const struct mfd_cell cros_ec_rtc_cells[] = {
+ { .name = "cros-ec-rtc" }
+};
+
static int ec_device_probe(struct platform_device *pdev)
{
int retval = -ENOMEM;
@@ -422,6 +426,18 @@ static int ec_device_probe(struct platform_device *pdev)
if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE))
cros_ec_sensors_register(ec);
+ /* Check whether this EC instance has RTC host command support */
+ if (cros_ec_check_features(ec, EC_FEATURE_RTC)) {
+ retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO,
+ cros_ec_rtc_cells,
+ ARRAY_SIZE(cros_ec_rtc_cells),
+ NULL, 0, NULL);
+ if (retval)
+ dev_err(ec->dev,
+ "failed to add cros-ec-rtc device: %d\n",
+ retval);
+ }
+
/* Take control of the lightbar from the EC. */
lb_manual_suspend_ctrl(ec, 1);
--
2.17.0
next prev parent reply other threads:[~2018-04-18 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 10:23 [RESEND PATCH v5 0/7] mfd: cros_ec: add subdevices and fixes Enric Balletbo i Serra
2018-04-18 10:23 ` [RESEND PATCH v5 1/7] mfd: cros_ec: fail early if we cannot identify the EC Enric Balletbo i Serra
2018-04-18 10:23 ` [RESEND PATCH v5 2/7] mfd: cros_ec: free IRQ automatically Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 3/7] mfd: cros_ec: Don't try to grab log when suspended Enric Balletbo i Serra
2018-04-18 10:24 ` Enric Balletbo i Serra [this message]
2018-04-18 10:24 ` [RESEND PATCH v5 5/7] mfd: cros_ec_dev: register shutdown function for debugfs Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 6/7] mfd: cros_ec_i2c: add ACPI module device table Enric Balletbo i Serra
2018-04-18 10:24 ` [RESEND PATCH v5 7/7] mfd: cros_ec_i2c: moving the system sleep pm ops to late Enric Balletbo i Serra
2018-05-18 13:45 ` [RESEND PATCH v5 0/7] mfd: cros_ec: add subdevices and fixes Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418102405.17790-5-enric.balletbo@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®