* [PATCH] x86/iommu: Fix a typo in a macro parameter
@ 2018-06-06 5:10 Masatake YAMATO
2018-06-06 10:37 ` Thomas Gleixner
0 siblings, 1 reply; 6+ messages in thread
From: Masatake YAMATO @ 2018-06-06 5:10 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, yamato
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
arch/x86/include/asm/iommu_table.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
index 1fb3fd1a83c2..2a0d5f7d1ed1 100644
--- a/arch/x86/include/asm/iommu_table.h
+++ b/arch/x86/include/asm/iommu_table.h
@@ -66,7 +66,7 @@ struct iommu_table_entry {
#define IOMMU_INIT_POST(_detect) \
__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0)
-#define IOMMU_INIT_POST_FINISH(detect) \
+#define IOMMU_INIT_POST_FINISH(_detect) \
__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)
/*
--
2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
2018-06-06 5:10 [PATCH] x86/iommu: Fix a typo in a macro parameter Masatake YAMATO
@ 2018-06-06 10:37 ` Thomas Gleixner
2018-06-06 11:15 ` Masatake YAMATO
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2018-06-06 10:37 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: x86, LKML, Joerg Roedel
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value. That's not a typo, that's
a functional change and both the subject line and the changelog itself
should be explanatory.
Thanks,
tglx
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> ---
> arch/x86/include/asm/iommu_table.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
> index 1fb3fd1a83c2..2a0d5f7d1ed1 100644
> --- a/arch/x86/include/asm/iommu_table.h
> +++ b/arch/x86/include/asm/iommu_table.h
> @@ -66,7 +66,7 @@ struct iommu_table_entry {
> #define IOMMU_INIT_POST(_detect) \
> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0)
>
> -#define IOMMU_INIT_POST_FINISH(detect) \
> +#define IOMMU_INIT_POST_FINISH(_detect) \
> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)
>
> /*
> --
> 2.17.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
2018-06-06 10:37 ` Thomas Gleixner
@ 2018-06-06 11:15 ` Masatake YAMATO
2018-06-06 12:10 ` Thomas Gleixner
0 siblings, 1 reply; 6+ messages in thread
From: Masatake YAMATO @ 2018-06-06 11:15 UTC (permalink / raw)
To: tglx; +Cc: x86, linux-kernel, joro
On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>
> Can you please explain why 0 is the wrong value.
I don't know such constants, 0 and 1.
What I change is just the name of macro parameter as
s/detect/_detect/
I don't change the definition of macro.
Masatake YAMATO
> That's not a typo, that's
> a functional change and both the subject line and the changelog itself
> should be explanatory.
>
> Thanks,
>
> tglx
>
>> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>> ---
>> arch/x86/include/asm/iommu_table.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
>> index 1fb3fd1a83c2..2a0d5f7d1ed1 100644
>> --- a/arch/x86/include/asm/iommu_table.h
>> +++ b/arch/x86/include/asm/iommu_table.h
>> @@ -66,7 +66,7 @@ struct iommu_table_entry {
>> #define IOMMU_INIT_POST(_detect) \
>> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0)
>>
>> -#define IOMMU_INIT_POST_FINISH(detect) \
>> +#define IOMMU_INIT_POST_FINISH(_detect) \
>> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)
>>
>> /*
>> --
>> 2.17.0
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
2018-06-06 11:15 ` Masatake YAMATO
@ 2018-06-06 12:10 ` Thomas Gleixner
2018-06-06 12:41 ` Thomas Gleixner
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2018-06-06 12:10 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: x86, linux-kernel, joro
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
> On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Wed, 6 Jun 2018, Masatake YAMATO wrote:
> >
> > Can you please explain why 0 is the wrong value.
>
> I don't know such constants, 0 and 1.
>
> What I change is just the name of macro parameter as
>
> s/detect/_detect/
OOps. Misread the patch. Sorry.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
2018-06-06 12:10 ` Thomas Gleixner
@ 2018-06-06 12:41 ` Thomas Gleixner
2018-06-06 14:03 ` Masatake YAMATO
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2018-06-06 12:41 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: x86, linux-kernel, joro
On Wed, 6 Jun 2018, Thomas Gleixner wrote:
> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
> > On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> > > On Wed, 6 Jun 2018, Masatake YAMATO wrote:
> > >
> > > Can you please explain why 0 is the wrong value.
> >
> > I don't know such constants, 0 and 1.
> >
> > What I change is just the name of macro parameter as
> >
> > s/detect/_detect/
>
> OOps. Misread the patch. Sorry.
But the fix is pretty pointless. IOMMU_INIT_POST_FINISH() is completely
unused and should just be removed.
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
2018-06-06 12:41 ` Thomas Gleixner
@ 2018-06-06 14:03 ` Masatake YAMATO
0 siblings, 0 replies; 6+ messages in thread
From: Masatake YAMATO @ 2018-06-06 14:03 UTC (permalink / raw)
To: tglx; +Cc: x86, linux-kernel, joro
On Wed, 6 Jun 2018 14:41:57 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 6 Jun 2018, Thomas Gleixner wrote:
>> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>> > On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
>> > > On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>> > >
>> > > Can you please explain why 0 is the wrong value.
>> >
>> > I don't know such constants, 0 and 1.
>> >
>> > What I change is just the name of macro parameter as
>> >
>> > s/detect/_detect/
>>
>> OOps. Misread the patch. Sorry.
>
> But the fix is pretty pointless. IOMMU_INIT_POST_FINISH() is completely
> unused and should just be removed.
Oh, I see. Thank you for taking your time.
Masatake YAMATO
> Thanks,
>
> tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-06 14:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-06 5:10 [PATCH] x86/iommu: Fix a typo in a macro parameter Masatake YAMATO
2018-06-06 10:37 ` Thomas Gleixner
2018-06-06 11:15 ` Masatake YAMATO
2018-06-06 12:10 ` Thomas Gleixner
2018-06-06 12:41 ` Thomas Gleixner
2018-06-06 14:03 ` Masatake YAMATO
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®