* [PATCH] power: supply: max77693_charger: fix unintentional fall-through
@ 2018-07-17 21:47 Gustavo A. R. Silva
2018-07-18 6:14 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-17 21:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Sebastian Reichel
Cc: linux-pm, linux-kernel, Gustavo A. R. Silva
It seems that a *break* is missing in order to avoid a fall-through.
Otherwise, the calculation of *data* makes no sense.
Addresses-Coverity-ID: 1271172 ("Missing break in switch")
Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/power/supply/max77693_charger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/max77693_charger.c b/drivers/power/supply/max77693_charger.c
index 6c78884..749c792 100644
--- a/drivers/power/supply/max77693_charger.c
+++ b/drivers/power/supply/max77693_charger.c
@@ -567,6 +567,7 @@ static int max77693_set_charge_input_threshold_volt(struct max77693_charger *chg
case 4800000:
case 4900000:
data = (uvolt - 4700000) / 100000;
+ break;
default:
dev_err(chg->dev, "Wrong value for charge input voltage regulation threshold\n");
return -EINVAL;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through
2018-07-17 21:47 [PATCH] power: supply: max77693_charger: fix unintentional fall-through Gustavo A. R. Silva
@ 2018-07-18 6:14 ` Krzysztof Kozlowski
2018-07-19 13:54 ` Gustavo A. R. Silva
2018-07-22 22:17 ` Sebastian Reichel
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-07-18 6:14 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Bartlomiej Zolnierkiewicz, Sebastian Reichel, linux-pm, linux-kernel
On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> It seems that a *break* is missing in order to avoid a fall-through.
> Otherwise, the calculation of *data* makes no sense.
>
> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/power/supply/max77693_charger.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through
2018-07-18 6:14 ` Krzysztof Kozlowski
@ 2018-07-19 13:54 ` Gustavo A. R. Silva
2018-07-22 22:17 ` Sebastian Reichel
1 sibling, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-19 13:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bartlomiej Zolnierkiewicz, Sebastian Reichel, linux-pm, linux-kernel
Hi Krzysztof,
On 07/18/2018 01:14 AM, Krzysztof Kozlowski wrote:
> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>> It seems that a *break* is missing in order to avoid a fall-through.
>> Otherwise, the calculation of *data* makes no sense.
>>
>> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
>> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/power/supply/max77693_charger.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
BTW, I think this also should be tagged for stable.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through
2018-07-18 6:14 ` Krzysztof Kozlowski
2018-07-19 13:54 ` Gustavo A. R. Silva
@ 2018-07-22 22:17 ` Sebastian Reichel
2018-08-05 2:01 ` Gustavo A. R. Silva
1 sibling, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2018-07-22 22:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Gustavo A. R. Silva, Bartlomiej Zolnierkiewicz, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi,
On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote:
> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> > It seems that a *break* is missing in order to avoid a fall-through.
> > Otherwise, the calculation of *data* makes no sense.
> >
> > Addresses-Coverity-ID: 1271172 ("Missing break in switch")
> > Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> > drivers/power/supply/max77693_charger.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks, queued to power-supply's fixes branch.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through
2018-07-22 22:17 ` Sebastian Reichel
@ 2018-08-05 2:01 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-05 2:01 UTC (permalink / raw)
To: Sebastian Reichel, Krzysztof Kozlowski
Cc: Bartlomiej Zolnierkiewicz, linux-pm, linux-kernel
Hi Sebastian,
On 07/22/2018 05:17 PM, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote:
>> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>> It seems that a *break* is missing in order to avoid a fall-through.
>>> Otherwise, the calculation of *data* makes no sense.
>>>
>>> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
>>> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> ---
>>> drivers/power/supply/max77693_charger.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Thanks, queued to power-supply's fixes branch.
>
I think this should be tagged for stable.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-05 2:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 21:47 [PATCH] power: supply: max77693_charger: fix unintentional fall-through Gustavo A. R. Silva
2018-07-18 6:14 ` Krzysztof Kozlowski
2018-07-19 13:54 ` Gustavo A. R. Silva
2018-07-22 22:17 ` Sebastian Reichel
2018-08-05 2:01 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome