* [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support
@ 2018-08-28 17:22 Ray Jui
2018-09-17 15:01 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Ray Jui @ 2018-08-28 17:22 UTC (permalink / raw)
To: Lorenzo Pieralisi, Bjorn Helgaas
Cc: Bjorn Helgaas, linux-kernel, bcm-kernel-feedback-list, linux-pci,
Jitendra Bhivare, Ray Jui
From: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Fix previous incorrect logic that limits PAXC slot number to zero only.
In order for SRIOV/VF to work, we need to allow the slot number to be
greater than zero.
Fixes: 46560388c476c ("PCI: iproc: Allow multiple devices except on PAXC")
Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
---
drivers/pci/controller/pcie-iproc.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
index 3160e9342a2f..c20fd6bd68fd 100644
--- a/drivers/pci/controller/pcie-iproc.c
+++ b/drivers/pci/controller/pcie-iproc.c
@@ -630,14 +630,6 @@ static void __iomem *iproc_pcie_map_cfg_bus(struct iproc_pcie *pcie,
return (pcie->base + offset);
}
- /*
- * PAXC is connected to an internally emulated EP within the SoC. It
- * allows only one device.
- */
- if (pcie->ep_is_internal)
- if (slot > 0)
- return NULL;
-
return iproc_pcie_map_ep_cfg_reg(pcie, busno, slot, fn, where);
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support
2018-08-28 17:22 [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support Ray Jui
@ 2018-09-17 15:01 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2018-09-17 15:01 UTC (permalink / raw)
To: Ray Jui
Cc: Bjorn Helgaas, Bjorn Helgaas, linux-kernel,
bcm-kernel-feedback-list, linux-pci, Jitendra Bhivare
On Tue, Aug 28, 2018 at 10:22:58AM -0700, Ray Jui wrote:
> From: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
>
> Fix previous incorrect logic that limits PAXC slot number to zero only.
> In order for SRIOV/VF to work, we need to allow the slot number to be
> greater than zero.
>
> Fixes: 46560388c476c ("PCI: iproc: Allow multiple devices except on PAXC")
> Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 8 --------
> 1 file changed, 8 deletions(-)
Applied to pci/iproc for v4.20, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index 3160e9342a2f..c20fd6bd68fd 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -630,14 +630,6 @@ static void __iomem *iproc_pcie_map_cfg_bus(struct iproc_pcie *pcie,
> return (pcie->base + offset);
> }
>
> - /*
> - * PAXC is connected to an internally emulated EP within the SoC. It
> - * allows only one device.
> - */
> - if (pcie->ep_is_internal)
> - if (slot > 0)
> - return NULL;
> -
> return iproc_pcie_map_ep_cfg_reg(pcie, busno, slot, fn, where);
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 17:22 [PATCH] PCI: iproc: Remove PAXC slot check to allow VF support Ray Jui
2018-09-17 15:01 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®