* Re: [PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c [not found] <20180829220326.7447-1-xerofoify@gmail.com> @ 2018-08-30 8:28 ` Dan Carpenter 2018-08-30 12:49 ` Joe Perches 0 siblings, 1 reply; 2+ messages in thread From: Dan Carpenter @ 2018-08-30 8:28 UTC (permalink / raw) To: Nicholas Krause; +Cc: gregkh, devel, keescook, linux-kernel On Wed, Aug 29, 2018 at 06:03:26PM -0400, Nicholas Krause wrote: > Fix a checkpatch warning for the file, fwserial.c that warns about > alignment between parentheses and the line belows code not being > properly aligned with each other. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/staging/fwserial/fwserial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c > index fa0dd425b454..f9fcabe7afa1 100644 > --- a/drivers/staging/fwserial/fwserial.c > +++ b/drivers/staging/fwserial/fwserial.c > @@ -1328,7 +1328,7 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state) > if (state == -1) { > set_bit(STOP_TX, &port->flags); > ret = wait_event_interruptible_timeout(port->wait_tx, > - !test_bit(IN_TX, &port->flags), > + !test_bit(IN_TX, &port->flags), > 10); Now it goes over 80 characters and the "10);" isn't aligned properly. The original is fine. regards, dan carpenter ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c 2018-08-30 8:28 ` [PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c Dan Carpenter @ 2018-08-30 12:49 ` Joe Perches 0 siblings, 0 replies; 2+ messages in thread From: Joe Perches @ 2018-08-30 12:49 UTC (permalink / raw) To: Dan Carpenter, Nicholas Krause; +Cc: gregkh, devel, keescook, linux-kernel On Thu, 2018-08-30 at 11:28 +0300, Dan Carpenter wrote: > On Wed, Aug 29, 2018 at 06:03:26PM -0400, Nicholas Krause wrote: > > Fix a checkpatch warning for the file, fwserial.c that warns about > > alignment between parentheses and the line belows code not being > > properly aligned with each other. > > > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> Nick Krause? I wonder if after 4 years he has improved. > > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c [] > > @@ -1328,7 +1328,7 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state) > > if (state == -1) { > > set_bit(STOP_TX, &port->flags); > > ret = wait_event_interruptible_timeout(port->wait_tx, > > - !test_bit(IN_TX, &port->flags), > > + !test_bit(IN_TX, &port->flags), > > 10); > > Now it goes over 80 characters and the "10);" isn't aligned properly. > The original is fine. Perhaps not. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-30 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180829220326.7447-1-xerofoify@gmail.com>
2018-08-30 8:28 ` [PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c Dan Carpenter
2018-08-30 12:49 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®