* [PATCH] dsa device tree bindings: fix typo and wrong example [not found] ` <20181206130051.GA22343@amd> @ 2018-12-06 13:05 ` Pavel Machek 2018-12-06 13:28 ` Vokáč Michal 0 siblings, 1 reply; 4+ messages in thread From: Pavel Machek @ 2018-12-06 13:05 UTC (permalink / raw) To: andrew, vivien.didelot, netdev, f.fainelli Cc: buytenh, buytenh, nico, robh+dt, mark.rutland, devicetree, kernel list [-- Attachment #1: Type: text/plain, Size: 1165 bytes --] Fix typo and fix compatible value that is not actually permitted by the description in the example. Signed-off-by: Pavel Machek <pavel@ucw.cz> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt index feb007af13cb..abf1be036ac5 100644 --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt @@ -41,7 +41,7 @@ Optional properties: - mdio : Container of PHY and devices on the switches MDIO bus. - mdio? : Container of PHYs and devices on the external MDIO - bus. The node must contains a compatible string of + bus. The node must contain a compatible string of "marvell,mv88e6xxx-mdio-external" Example: @@ -80,7 +80,7 @@ Example: #interrupt-cells = <2>; switch0: switch@0 { - compatible = "marvell,mv88e6390"; + compatible = "marvell,mv88e6190"; reg = <0>; reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dsa device tree bindings: fix typo and wrong example 2018-12-06 13:05 ` [PATCH] dsa device tree bindings: fix typo and wrong example Pavel Machek @ 2018-12-06 13:28 ` Vokáč Michal 2019-01-07 18:49 ` Pavel Machek 0 siblings, 1 reply; 4+ messages in thread From: Vokáč Michal @ 2018-12-06 13:28 UTC (permalink / raw) To: Pavel Machek, andrew, vivien.didelot, netdev, f.fainelli Cc: buytenh, buytenh, nico, robh+dt, mark.rutland, devicetree, kernel list On 6.12.2018 14:05, Pavel Machek wrote: > > Fix typo and fix compatible value that is not actually permitted by the > description in the example. Ahoj Pavle, I think the subject should be more like: "dt-bindings: net: dsa: ..." BR, Michal > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt > index feb007af13cb..abf1be036ac5 100644 > --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt > +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt > @@ -41,7 +41,7 @@ Optional properties: > - mdio : Container of PHY and devices on the switches MDIO > bus. > - mdio? : Container of PHYs and devices on the external MDIO > - bus. The node must contains a compatible string of > + bus. The node must contain a compatible string of > "marvell,mv88e6xxx-mdio-external" > > Example: > @@ -80,7 +80,7 @@ Example: > #interrupt-cells = <2>; > > switch0: switch@0 { > - compatible = "marvell,mv88e6390"; > + compatible = "marvell,mv88e6190"; > reg = <0>; > reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>; > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dsa device tree bindings: fix typo and wrong example 2018-12-06 13:28 ` Vokáč Michal @ 2019-01-07 18:49 ` Pavel Machek 2019-01-07 18:53 ` Florian Fainelli 0 siblings, 1 reply; 4+ messages in thread From: Pavel Machek @ 2019-01-07 18:49 UTC (permalink / raw) To: Vokáč Michal, trivial Cc: andrew, vivien.didelot, netdev, f.fainelli, buytenh, buytenh, nico, robh+dt, mark.rutland, devicetree, kernel list [-- Attachment #1: Type: text/plain, Size: 1759 bytes --] On Thu 2018-12-06 13:28:56, Vokáč Michal wrote: > On 6.12.2018 14:05, Pavel Machek wrote: > > > > Fix typo and fix compatible value that is not actually permitted by the > > description in the example. > > Ahoj Pavle, I think the subject should be more like: > > "dt-bindings: net: dsa: ..." Ahoj! Well, retrying with different subject only makes sense if someone is interested. Rob, Andrew -- can you take the patch? Do you want me to edit the subject or can you just edit the subject while applying? Thanks, Pavel > BR, Michal > > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt > > index feb007af13cb..abf1be036ac5 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt > > @@ -41,7 +41,7 @@ Optional properties: > > - mdio : Container of PHY and devices on the switches MDIO > > bus. > > - mdio? : Container of PHYs and devices on the external MDIO > > - bus. The node must contains a compatible string of > > + bus. The node must contain a compatible string of > > "marvell,mv88e6xxx-mdio-external" > > > > Example: > > @@ -80,7 +80,7 @@ Example: > > #interrupt-cells = <2>; > > > > switch0: switch@0 { > > - compatible = "marvell,mv88e6390"; > > + compatible = "marvell,mv88e6190"; > > reg = <0>; > > reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>; > > > > > > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dsa device tree bindings: fix typo and wrong example 2019-01-07 18:49 ` Pavel Machek @ 2019-01-07 18:53 ` Florian Fainelli 0 siblings, 0 replies; 4+ messages in thread From: Florian Fainelli @ 2019-01-07 18:53 UTC (permalink / raw) To: Pavel Machek, Vokáč Michal, trivial Cc: andrew, vivien.didelot, netdev, buytenh, buytenh, nico, robh+dt, mark.rutland, devicetree, kernel list On 1/7/19 10:49 AM, Pavel Machek wrote: > On Thu 2018-12-06 13:28:56, Vokáč Michal wrote: >> On 6.12.2018 14:05, Pavel Machek wrote: >>> >>> Fix typo and fix compatible value that is not actually permitted by the >>> description in the example. >> >> Ahoj Pavle, I think the subject should be more like: >> >> "dt-bindings: net: dsa: ..." > > Ahoj! > > Well, retrying with different subject only makes sense if someone is > interested. Rob, Andrew -- can you take the patch? > > Do you want me to edit the subject or can you just edit the subject > while applying? The next steps would likely be for you to resubmit this patch with a re-subjected patch and I am fairly sure David can pick it up right away since this is not a functional change. > > Thanks, > Pavel > >> BR, Michal >> >>> >>> Signed-off-by: Pavel Machek <pavel@ucw.cz> >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt >>> index feb007af13cb..abf1be036ac5 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt >>> +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt >>> @@ -41,7 +41,7 @@ Optional properties: >>> - mdio : Container of PHY and devices on the switches MDIO >>> bus. >>> - mdio? : Container of PHYs and devices on the external MDIO >>> - bus. The node must contains a compatible string of >>> + bus. The node must contain a compatible string of >>> "marvell,mv88e6xxx-mdio-external" >>> >>> Example: >>> @@ -80,7 +80,7 @@ Example: >>> #interrupt-cells = <2>; >>> >>> switch0: switch@0 { >>> - compatible = "marvell,mv88e6390"; >>> + compatible = "marvell,mv88e6190"; >>> reg = <0>; >>> reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>; >>> >>> >>> > -- Florian ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-07 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181115195111.GA9946@amd>
[not found] ` <20181206130051.GA22343@amd>
2018-12-06 13:05 ` [PATCH] dsa device tree bindings: fix typo and wrong example Pavel Machek
2018-12-06 13:28 ` Vokáč Michal
2019-01-07 18:49 ` Pavel Machek
2019-01-07 18:53 ` Florian Fainelli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®