* [PATCH] hns3: prevent building without CONFIG_INET
@ 2018-12-10 20:44 Arnd Bergmann
2018-12-14 21:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-12-10 20:44 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S. Miller
Cc: Arnd Bergmann, Peng Li, Huazhong Tan, netdev, linux-kernel
We now get a link failure when CONFIG_INET is disabled, since
tcp_gro_complete is unavailable:
drivers/net/ethernet/hisilicon/hns3/hns3_enet.o: In function `hns3_set_gro_param':
hns3_enet.c:(.text+0x230c): undefined reference to `tcp_gro_complete'
Add an explicit CONFIG_INET dependency here to avoid the broken
configuration.
Fixes: a6d53b97a2e7 ("net: hns3: Adds GRO params to SKB for the stack")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/hisilicon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
index 25152715396b..fee4664c9189 100644
--- a/drivers/net/ethernet/hisilicon/Kconfig
+++ b/drivers/net/ethernet/hisilicon/Kconfig
@@ -118,6 +118,7 @@ config HNS3_ENET
tristate "Hisilicon HNS3 Ethernet Device Support"
default m
depends on 64BIT && PCI
+ depends on INET
---help---
This selects the Ethernet Driver for Hisilicon Network Subsystem 3 for hip08
family of SoCs. This module depends upon HNAE3 driver to access the HNAE3
--
2.20.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hns3: prevent building without CONFIG_INET
2018-12-10 20:44 [PATCH] hns3: prevent building without CONFIG_INET Arnd Bergmann
@ 2018-12-14 21:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-12-14 21:20 UTC (permalink / raw)
To: arnd
Cc: yisen.zhuang, salil.mehta, lipeng321, tanhuazhong, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Dec 2018 21:44:34 +0100
> We now get a link failure when CONFIG_INET is disabled, since
> tcp_gro_complete is unavailable:
>
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.o: In function `hns3_set_gro_param':
> hns3_enet.c:(.text+0x230c): undefined reference to `tcp_gro_complete'
>
> Add an explicit CONFIG_INET dependency here to avoid the broken
> configuration.
>
> Fixes: a6d53b97a2e7 ("net: hns3: Adds GRO params to SKB for the stack")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-14 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 20:44 [PATCH] hns3: prevent building without CONFIG_INET Arnd Bergmann
2018-12-14 21:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®