* [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply
@ 2019-01-18 13:32 Stefan Agner
2019-01-21 8:35 ` Philippe Schenker
2019-01-21 14:30 ` Stefan Agner
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Agner @ 2019-01-18 13:32 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: max.krummenacher, marcel.ziswiler, dev, kernel, fabio.estevam,
linux-imx, linux-arm-kernel, linux-kernel, Stefan Agner
Use the VDD I/O rail as phy-supply regulator. Technically, the
regulator has multiple rails, but currently the driver only
supports a single phy-supply. The VDD I/O rail has the highest
power consumption when software power down is used and hence
the highest saving potential.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 0b47aecf336a..cf66f9ececbd 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
@@ -241,6 +241,7 @@
phy-handle = <ðphy>;
phy-reset-duration = <10>;
phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+ phy-supply = <&vgen5_reg>;
status = "okay";
mdio {
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply
2019-01-18 13:32 [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply Stefan Agner
@ 2019-01-21 8:35 ` Philippe Schenker
2019-01-21 14:30 ` Stefan Agner
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Schenker @ 2019-01-21 8:35 UTC (permalink / raw)
To: Stefan Agner, shawnguo, s.hauer
Cc: max.krummenacher, marcel.ziswiler, kernel, fabio.estevam,
linux-imx, linux-arm-kernel, linux-kernel
On Fri, 2019-01-18 at 14:32 +0100, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
> phy-handle = <ðphy>;
> phy-reset-duration = <10>;
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> + phy-supply = <&vgen5_reg>;
> status = "okay";
>
> mdio {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply
2019-01-18 13:32 [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply Stefan Agner
2019-01-21 8:35 ` Philippe Schenker
@ 2019-01-21 14:30 ` Stefan Agner
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Agner @ 2019-01-21 14:30 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: max.krummenacher, marcel.ziswiler, dev, kernel, fabio.estevam,
linux-imx, linux-arm-kernel, linux-kernel
On 18.01.2019 14:32, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.
Please don't merge this patch. The vgen5_reg is also used as a pull-up
for USB ID pin, it would not be safe for the FEC driver to disable this
rail.
--
Stefan
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
> phy-handle = <ðphy>;
> phy-reset-duration = <10>;
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> + phy-supply = <&vgen5_reg>;
> status = "okay";
>
> mdio {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-21 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 13:32 [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply Stefan Agner
2019-01-21 8:35 ` Philippe Schenker
2019-01-21 14:30 ` Stefan Agner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®