* [PATCH 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit
2019-02-19 16:15 [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR() Codrin.Ciubotariu
@ 2019-02-19 16:15 ` Codrin.Ciubotariu
2019-02-19 16:20 ` [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR() Codrin.Ciubotariu
1 sibling, 0 replies; 3+ messages in thread
From: Codrin.Ciubotariu @ 2019-02-19 16:15 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: dannenberg, m-stecklein, afd, alsa-devel, linux-kernel,
Codrin.Ciubotariu
From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
The ADCs are sleeping when the SLEEP bit is set and running when it's
cleared, so the bit should be inverted.
Tested on pcm1863.
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
sound/soc/codecs/pcm186x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
index 7947279243f9..4477d678797f 100644
--- a/sound/soc/codecs/pcm186x.c
+++ b/sound/soc/codecs/pcm186x.c
@@ -157,7 +157,7 @@ static const struct snd_soc_dapm_widget pcm1863_dapm_widgets[] = {
* Put the codec into SLEEP mode when not in use, allowing the
* Energysense mechanism to operate.
*/
- SND_SOC_DAPM_ADC("ADC", "HiFi Capture", PCM186X_POWER_CTRL, 1, 0),
+ SND_SOC_DAPM_ADC("ADC", "HiFi Capture", PCM186X_POWER_CTRL, 1, 1),
};
static const struct snd_soc_dapm_widget pcm1865_dapm_widgets[] = {
@@ -183,8 +183,8 @@ static const struct snd_soc_dapm_widget pcm1865_dapm_widgets[] = {
* Put the codec into SLEEP mode when not in use, allowing the
* Energysense mechanism to operate.
*/
- SND_SOC_DAPM_ADC("ADC1", "HiFi Capture 1", PCM186X_POWER_CTRL, 1, 0),
- SND_SOC_DAPM_ADC("ADC2", "HiFi Capture 2", PCM186X_POWER_CTRL, 1, 0),
+ SND_SOC_DAPM_ADC("ADC1", "HiFi Capture 1", PCM186X_POWER_CTRL, 1, 1),
+ SND_SOC_DAPM_ADC("ADC2", "HiFi Capture 2", PCM186X_POWER_CTRL, 1, 1),
};
static const struct snd_soc_dapm_route pcm1863_dapm_routes[] = {
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR()
2019-02-19 16:15 [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR() Codrin.Ciubotariu
2019-02-19 16:15 ` [PATCH 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit Codrin.Ciubotariu
@ 2019-02-19 16:20 ` Codrin.Ciubotariu
1 sibling, 0 replies; 3+ messages in thread
From: Codrin.Ciubotariu @ 2019-02-19 16:20 UTC (permalink / raw)
To: lgirdwood, broonie; +Cc: dannenberg, m-stecklein, afd, alsa-devel, linux-kernel
On 19.02.2019 18:15, Codrin Ciubotariu - M19940 wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/codecs/pcm186x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..7947279243f9 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -6,7 +6,6 @@
> * Andreas Dannenberg <dannenberg@ti.com>
> * Andrew F. Davis <afd@ti.com>
> */
> -
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/init.h>
> @@ -42,7 +41,7 @@ struct pcm186x_priv {
> bool is_master_mode;
> };
>
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>
> static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
> SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
>
the title is wrong, there is no DECLARE_TLV_DB_LINEAR()present. Will
send v2.
Best regards,
Codrin
^ permalink raw reply [flat|nested] 3+ messages in thread