* [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64)
@ 2019-02-21 16:06 David Abdurachmanov
2019-02-21 20:48 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: David Abdurachmanov @ 2019-02-21 16:06 UTC (permalink / raw)
To: daniel.lezcano, tglx, linux-kernel; +Cc: David Abdurachmanov
Resending to incl. a proper mailing list and maintainers (not suggested
by scripts/get_maintainer.pl)
This is only used on arm and arm64 platforms. Other timers also seem
to depend on (ARM || ARM64).
After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to
add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
drivers/clocksource/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index a9e26f6a81a1..7593d80e1c88 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER
config ARM_TIMER_SP804
bool "Support for Dual Timer SP804 module"
- depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
+ depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
select CLKSRC_MMIO
select TIMER_OF if OF
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64)
2019-02-21 16:06 [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64) David Abdurachmanov
@ 2019-02-21 20:48 ` Daniel Lezcano
2019-02-21 21:43 ` David Abdurachmanov
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2019-02-21 20:48 UTC (permalink / raw)
To: David Abdurachmanov, tglx, linux-kernel
On 21/02/2019 17:06, David Abdurachmanov wrote:
> Resending to incl. a proper mailing list and maintainers (not suggested
> by scripts/get_maintainer.pl)
>
> This is only used on arm and arm64 platforms. Other timers also seem
> to depend on (ARM || ARM64).
>
> After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to
> add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index a9e26f6a81a1..7593d80e1c88 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER
>
> config ARM_TIMER_SP804
> bool "Support for Dual Timer SP804 module"
> - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
> + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
What about adding the COMPILE_TEST option:
bool "Support for Dual Timer SP804 module" if COMPILE_TEST
but not add the ARM || ARM64 dependency ?
> select CLKSRC_MMIO
> select TIMER_OF if OF
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64)
2019-02-21 20:48 ` Daniel Lezcano
@ 2019-02-21 21:43 ` David Abdurachmanov
2019-02-22 8:22 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: David Abdurachmanov @ 2019-02-21 21:43 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: Thomas Gleixner, linux-kernel
On Thu, Feb 21, 2019 at 9:48 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 21/02/2019 17:06, David Abdurachmanov wrote:
> > Resending to incl. a proper mailing list and maintainers (not suggested
> > by scripts/get_maintainer.pl)
> >
> > This is only used on arm and arm64 platforms. Other timers also seem
> > to depend on (ARM || ARM64).
> >
> > After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to
> > add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > ---
> > drivers/clocksource/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index a9e26f6a81a1..7593d80e1c88 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER
> >
> > config ARM_TIMER_SP804
> > bool "Support for Dual Timer SP804 module"
> > - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
> > + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
>
> What about adding the COMPILE_TEST option:
>
> bool "Support for Dual Timer SP804 module" if COMPILE_TEST
>
> but not add the ARM || ARM64 dependency ?
>
That would work, but is that consistent with other timers?
Looks like a number of them have depends on + COMPILE_TEST.
Some examples:
config ROCKCHIP_TIMER
bool "Rockchip timer driver" if COMPILE_TEST
depends on ARM || ARM64
config ARMADA_370_XP_TIMER
bool "Armada 370 and XP timer driver" if COMPILE_TEST
depends on ARM
config ORION_TIMER
bool "Orion timer driver" if COMPILE_TEST
depends on ARM
config ARM_GLOBAL_TIMER
bool "Support for the ARM global timer" if COMPILE_TEST
select TIMER_OF if OF
depends on ARM
config CLKSRC_EXYNOS_MCT
bool "Exynos multi core timer driver" if COMPILE_TEST
depends on ARM || ARM64
david
> > select CLKSRC_MMIO
> > select TIMER_OF if OF
> >
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64)
2019-02-21 21:43 ` David Abdurachmanov
@ 2019-02-22 8:22 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2019-02-22 8:22 UTC (permalink / raw)
To: David Abdurachmanov; +Cc: Thomas Gleixner, linux-kernel
On 21/02/2019 22:43, David Abdurachmanov wrote:
> On Thu, Feb 21, 2019 at 9:48 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 21/02/2019 17:06, David Abdurachmanov wrote:
>>> Resending to incl. a proper mailing list and maintainers (not suggested
>>> by scripts/get_maintainer.pl)
>>>
>>> This is only used on arm and arm64 platforms. Other timers also seem
>>> to depend on (ARM || ARM64).
>>>
>>> After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to
>>> add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
>>>
>>> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>>> ---
>>> drivers/clocksource/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> index a9e26f6a81a1..7593d80e1c88 100644
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER
>>>
>>> config ARM_TIMER_SP804
>>> bool "Support for Dual Timer SP804 module"
>>> - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
>>> + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
>>
>> What about adding the COMPILE_TEST option:
>>
>> bool "Support for Dual Timer SP804 module" if COMPILE_TEST
>>
>> but not add the ARM || ARM64 dependency ?
>>
>
> That would work, but is that consistent with other timers?
Yes, I'm making all timers to converge to COMPILE_TEST option.
> Looks like a number of them have depends on + COMPILE_TEST.
>
> Some examples:
>
> config ROCKCHIP_TIMER
> bool "Rockchip timer driver" if COMPILE_TEST
> depends on ARM || ARM64
>
> config ARMADA_370_XP_TIMER
> bool "Armada 370 and XP timer driver" if COMPILE_TEST
> depends on ARM
>
> config ORION_TIMER
> bool "Orion timer driver" if COMPILE_TEST
> depends on ARM
>
> config ARM_GLOBAL_TIMER
> bool "Support for the ARM global timer" if COMPILE_TEST
> select TIMER_OF if OF
> depends on ARM
>
> config CLKSRC_EXYNOS_MCT
> bool "Exynos multi core timer driver" if COMPILE_TEST
> depends on ARM || ARM64
>
> david
>
>>> select CLKSRC_MMIO
>>> select TIMER_OF if OF
>>>
>>>
>>
>>
>> --
>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>> <http://twitter.com/#!/linaroorg> Twitter |
>> <http://www.linaro.org/linaro-blog/> Blog
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-22 8:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 16:06 [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64) David Abdurachmanov
2019-02-21 20:48 ` Daniel Lezcano
2019-02-21 21:43 ` David Abdurachmanov
2019-02-22 8:22 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®