* [PATCH] au0828: minor fix to a misleading comment in _close()
@ 2019-02-22 17:45 Shuah Khan
2019-02-23 1:44 ` Niklas Söderlund
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2019-02-22 17:45 UTC (permalink / raw)
To: mchehab, hans.verkuil, keescook, niklas.soderlund+renesas,
sakari.ailus, shuah, colin.king
Cc: linux-media, linux-kernel
Fix misleading comment in _close()
Signed-off-by: Shuah Khan <shuah@kernel.org>
---
drivers/media/usb/au0828/au0828-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
index 7876c897cc1d..08f566006a1f 100644
--- a/drivers/media/usb/au0828/au0828-video.c
+++ b/drivers/media/usb/au0828/au0828-video.c
@@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
* so the s_power callback are silently ignored.
* So, the current logic here does the following:
* Disable (put tuner to sleep) when
- * - ALSA and DVB aren't not streaming;
+ * - ALSA and DVB aren't streaming;
* - the last V4L2 file handler is closed.
*
* FIXME:
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] au0828: minor fix to a misleading comment in _close()
2019-02-22 17:45 [PATCH] au0828: minor fix to a misleading comment in _close() Shuah Khan
@ 2019-02-23 1:44 ` Niklas Söderlund
2019-02-25 12:35 ` shuah
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Söderlund @ 2019-02-23 1:44 UTC (permalink / raw)
To: Shuah Khan
Cc: mchehab, hans.verkuil, keescook, sakari.ailus, colin.king,
linux-media, linux-kernel
Hi Shuah,
Thanks for your patch.
On 2019-02-22 10:45:59 -0700, Shuah Khan wrote:
> Fix misleading comment in _close()
>
> Signed-off-by: Shuah Khan <shuah@kernel.org>
> ---
> drivers/media/usb/au0828/au0828-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> index 7876c897cc1d..08f566006a1f 100644
> --- a/drivers/media/usb/au0828/au0828-video.c
> +++ b/drivers/media/usb/au0828/au0828-video.c
> @@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
> * so the s_power callback are silently ignored.
> * So, the current logic here does the following:
> * Disable (put tuner to sleep) when
> - * - ALSA and DVB aren't not streaming;
> + * - ALSA and DVB aren't streaming;
Nit-picking, as you are modifying the line anyhow I would s/;/./
With or without this changed,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> * - the last V4L2 file handler is closed.
> *
> * FIXME:
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] au0828: minor fix to a misleading comment in _close()
2019-02-23 1:44 ` Niklas Söderlund
@ 2019-02-25 12:35 ` shuah
0 siblings, 0 replies; 3+ messages in thread
From: shuah @ 2019-02-25 12:35 UTC (permalink / raw)
To: Niklas Söderlund
Cc: mchehab, hans.verkuil, keescook, sakari.ailus, colin.king,
linux-media, linux-kernel, shuah
On 2/22/19 6:44 PM, Niklas Söderlund wrote:
> Hi Shuah,
>
> Thanks for your patch.
>
> On 2019-02-22 10:45:59 -0700, Shuah Khan wrote:
>> Fix misleading comment in _close()
>>
>> Signed-off-by: Shuah Khan <shuah@kernel.org>
>> ---
>> drivers/media/usb/au0828/au0828-video.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
>> index 7876c897cc1d..08f566006a1f 100644
>> --- a/drivers/media/usb/au0828/au0828-video.c
>> +++ b/drivers/media/usb/au0828/au0828-video.c
>> @@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
>> * so the s_power callback are silently ignored.
>> * So, the current logic here does the following:
>> * Disable (put tuner to sleep) when
>> - * - ALSA and DVB aren't not streaming;
>> + * - ALSA and DVB aren't streaming;
>
> Nit-picking, as you are modifying the line anyhow I would s/;/./
> With or without this changed,
Thanks. I didn't notice that one. I might as fix it. Will send v2.
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-25 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 17:45 [PATCH] au0828: minor fix to a misleading comment in _close() Shuah Khan
2019-02-23 1:44 ` Niklas Söderlund
2019-02-25 12:35 ` shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome