mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yuyang Du <duyuyang@gmail.com>
To: peterz@infradead.org, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, Yuyang Du <duyuyang@gmail.com>
Subject: [PATCH 4/8] locking/lockdep: Remove useless conditional macro
Date: Tue, 26 Feb 2019 18:03:23 +0800	[thread overview]
Message-ID: <20190226100327.19340-5-duyuyang@gmail.com> (raw)
In-Reply-To: <20190226100327.19340-1-duyuyang@gmail.com>

Since #defined(CONFIG_PROVE_LOCKING) is used in the scope of #ifdef
CONFIG_PROVE_LOCKING, it can be removed.

Signed-off-by: Yuyang Du <duyuyang@gmail.com>
---
 kernel/locking/lockdep.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 8b8495e..0610c0b 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -1331,7 +1331,7 @@ unsigned long lockdep_count_backward_deps(struct lock_class *class)
 	return result;
 }
 
-#if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_PROVE_LOCKING)
+#if defined(CONFIG_TRACE_IRQFLAGS)
 /*
  * Forwards and backwards subgraph searching, for the purposes of
  * proving that two subgraphs can be connected by a new dependency
@@ -1709,7 +1709,7 @@ static inline void inc_chains(void)
 	nr_process_chains++;
 }
 
-#endif
+#endif /* CONFIG_TRACE_IRQFLAGS */
 
 static void print_deadlock_scenario(struct held_lock *nxt,
 				    struct held_lock *prv)
@@ -2363,7 +2363,7 @@ static inline int validate_chain(struct task_struct *curr,
 {
 	return 1;
 }
-#endif
+#endif /* CONFIG_PROVE_LOCKING */
 
 /*
  * We are building curr_chain_key incrementally, so double-check
-- 
1.8.3.1


  parent reply	other threads:[~2019-02-26 10:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 10:03 [PATCH 0/8] locking/lockdep: Add comments and make some code adjustments Yuyang Du
2019-02-26 10:03 ` [PATCH 1/8] locking/lockdep: Change all print_*() return type to void Yuyang Du
2019-02-26 10:03 ` [PATCH 2/8] locking/lockdep: Add description and explanation in lockdep design doc Yuyang Du
2019-02-26 10:03 ` [PATCH 3/8] locking/lockdep: Adjust lock usage bit character checks Yuyang Du
2019-02-26 10:03 ` Yuyang Du [this message]
2019-02-26 10:03 ` [PATCH 5/8] locking/lockdep: Adjust indents for some lines Yuyang Du
2019-02-26 10:03 ` [PATCH 6/8] locking/lockdep: Print right depth for chain key colission Yuyang Du
2019-02-26 10:03 ` [PATCH 7/8] locking/lockdep: Update obsolete struct field description Yuyang Du
2019-02-26 10:03 ` [PATCH 8/8] locking/lockdep: Consider zapped locks when printing lock chains in /proc Yuyang Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226100327.19340-5-duyuyang@gmail.com \
    --to=duyuyang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome