From: Yuyang Du <duyuyang@gmail.com>
To: peterz@infradead.org, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, Yuyang Du <duyuyang@gmail.com>
Subject: [PATCH 6/8] locking/lockdep: Print right depth for chain key colission
Date: Tue, 26 Feb 2019 18:03:25 +0800 [thread overview]
Message-ID: <20190226100327.19340-7-duyuyang@gmail.com> (raw)
In-Reply-To: <20190226100327.19340-1-duyuyang@gmail.com>
Since chains are separated by irq context, so when printing a chain the
depth should be consistent with it.
Signed-off-by: Yuyang Du <duyuyang@gmail.com>
---
kernel/locking/lockdep.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 55270938..ec4f0c6 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -2061,10 +2061,11 @@ static u64 print_chain_key_iteration(int class_idx, u64 chain_key)
struct held_lock *hlock;
u64 chain_key = 0;
int depth = curr->lockdep_depth;
- int i;
+ int i = get_first_held_lock(curr, hlock_next);
- printk("depth: %u\n", depth + 1);
- for (i = get_first_held_lock(curr, hlock_next); i < depth; i++) {
+ printk("depth: %u (irq_context %u)\n", depth - i + 1,
+ hlock_next->irq_context);
+ for (i; i < depth; i++) {
hlock = curr->held_locks + i;
chain_key = print_chain_key_iteration(hlock->class_idx, chain_key);
--
1.8.3.1
next prev parent reply other threads:[~2019-02-26 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 10:03 [PATCH 0/8] locking/lockdep: Add comments and make some code adjustments Yuyang Du
2019-02-26 10:03 ` [PATCH 1/8] locking/lockdep: Change all print_*() return type to void Yuyang Du
2019-02-26 10:03 ` [PATCH 2/8] locking/lockdep: Add description and explanation in lockdep design doc Yuyang Du
2019-02-26 10:03 ` [PATCH 3/8] locking/lockdep: Adjust lock usage bit character checks Yuyang Du
2019-02-26 10:03 ` [PATCH 4/8] locking/lockdep: Remove useless conditional macro Yuyang Du
2019-02-26 10:03 ` [PATCH 5/8] locking/lockdep: Adjust indents for some lines Yuyang Du
2019-02-26 10:03 ` Yuyang Du [this message]
2019-02-26 10:03 ` [PATCH 7/8] locking/lockdep: Update obsolete struct field description Yuyang Du
2019-02-26 10:03 ` [PATCH 8/8] locking/lockdep: Consider zapped locks when printing lock chains in /proc Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226100327.19340-7-duyuyang@gmail.com \
--to=duyuyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome