mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yuyang Du <duyuyang@gmail.com>
To: peterz@infradead.org, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, Yuyang Du <duyuyang@gmail.com>
Subject: [PATCH 8/8] locking/lockdep: Consider zapped locks when printing lock chains in /proc
Date: Tue, 26 Feb 2019 18:03:27 +0800	[thread overview]
Message-ID: <20190226100327.19340-9-duyuyang@gmail.com> (raw)
In-Reply-To: <20190226100327.19340-1-duyuyang@gmail.com>

It is not rare to spot empty lock chains in /proc/lockdep_chains, where only
shows irq_context but not the locks, which is useless and makes people
confused.

This happens because the chained lock classes are freeed, so consider this
when printing the lock chains.

Signed-off-by: Yuyang Du <duyuyang@gmail.com>
---
 kernel/locking/lockdep_proc.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
index 3d31f9b..47a6f4f 100644
--- a/kernel/locking/lockdep_proc.c
+++ b/kernel/locking/lockdep_proc.c
@@ -127,7 +127,7 @@ static int lc_show(struct seq_file *m, void *v)
 {
 	struct lock_chain *chain = v;
 	struct lock_class *class;
-	int i;
+	int i, nr_locks = 0;
 
 	if (v == SEQ_START_TOKEN) {
 		if (nr_chain_hlocks > MAX_LOCKDEP_CHAIN_HLOCKS)
@@ -136,18 +136,28 @@ static int lc_show(struct seq_file *m, void *v)
 		return 0;
 	}
 
-	seq_printf(m, "irq_context: %d\n", chain->irq_context);
-
 	for (i = 0; i < chain->depth; i++) {
 		class = lock_chain_get_class(chain, i);
+		/*
+		 * Is this lock class zapped?
+		 */
 		if (!class->key)
 			continue;
 
+		if (!nr_locks++)
+			seq_printf(m, "irq_context: %d\n", chain->irq_context);
+
 		seq_printf(m, "[%p] ", class->key);
 		print_name(m, class);
 		seq_puts(m, "\n");
 	}
-	seq_puts(m, "\n");
+
+	if (nr_locks) {
+		if (nr_locks != chain->depth)
+			seq_printf(m, "(chain has %d zapped classes)\n",
+				   chain->depth - nr_locks);
+		seq_puts(m, "\n");
+	}
 
 	return 0;
 }
-- 
1.8.3.1


      parent reply	other threads:[~2019-02-26 10:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 10:03 [PATCH 0/8] locking/lockdep: Add comments and make some code adjustments Yuyang Du
2019-02-26 10:03 ` [PATCH 1/8] locking/lockdep: Change all print_*() return type to void Yuyang Du
2019-02-26 10:03 ` [PATCH 2/8] locking/lockdep: Add description and explanation in lockdep design doc Yuyang Du
2019-02-26 10:03 ` [PATCH 3/8] locking/lockdep: Adjust lock usage bit character checks Yuyang Du
2019-02-26 10:03 ` [PATCH 4/8] locking/lockdep: Remove useless conditional macro Yuyang Du
2019-02-26 10:03 ` [PATCH 5/8] locking/lockdep: Adjust indents for some lines Yuyang Du
2019-02-26 10:03 ` [PATCH 6/8] locking/lockdep: Print right depth for chain key colission Yuyang Du
2019-02-26 10:03 ` [PATCH 7/8] locking/lockdep: Update obsolete struct field description Yuyang Du
2019-02-26 10:03 ` Yuyang Du [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226100327.19340-9-duyuyang@gmail.com \
    --to=duyuyang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome