From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.19 15/44] ASoC: rsnd: fixup rsnd_ssi_master_clk_start() user count check
Date: Mon, 11 Mar 2019 15:56:31 -0400 [thread overview]
Message-ID: <20190311195700.138462-15-sashal@kernel.org> (raw)
In-Reply-To: <20190311195700.138462-1-sashal@kernel.org>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[ Upstream commit d9111d36024de07784f2e1ba2ccf70b16035f378 ]
commit 4d230d1271064 ("ASoC: rsnd: fixup not to call clk_get/set
under non-atomic") added new rsnd_ssi_prepare() and moved
rsnd_ssi_master_clk_start() to .prepare.
But, ssi user count (= ssi->usrcnt) is incremented at .init
(= rsnd_ssi_init()).
Because of these timing exchange, ssi->usrcnt check at
rsnd_ssi_master_clk_start() should be adjusted.
Otherwise, 2nd master clock setup will be no check.
This patch fixup this issue.
Fixes: commit 4d230d1271064 ("ASoC: rsnd: fixup not to call clk_get/set under non-atomic")
Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Reported-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/soc/sh/rcar/ssi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index a566dae3ec8a..9410e0a9b14b 100644
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -283,7 +283,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
if (rsnd_ssi_is_multi_slave(mod, io))
return 0;
- if (ssi->usrcnt > 1) {
+ if (ssi->usrcnt > 0) {
if (ssi->rate != rate) {
dev_err(dev, "SSI parent/child should use same rate\n");
return -EINVAL;
--
2.19.1
next prev parent reply other threads:[~2019-03-11 19:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 19:56 [PATCH AUTOSEL 4.19 01/44] drm/imx: ignore plane updates on disabled crtcs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 02/44] gpu: ipu-v3: Fix i.MX51 CSI control registers offset Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 03/44] drm/imx: imx-ldb: add missing of_node_puts Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 04/44] gpu: ipu-v3: Fix CSI offsets for imx53 Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 05/44] ASoC: rt5682: Correct the setting while select ASRC clk for AD/DA filter Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 06/44] clocksource: timer-ti-dm: Fix pwm dmtimer usage of fck reparenting Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 07/44] KVM: arm/arm64: vgic: Make vgic_dist->lpi_list_lock a raw_spinlock Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 08/44] arm64: dts: rockchip: fix graph_port warning on rk3399 bob kevin and excavator Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 09/44] s390/dasd: fix using offset into zero size array error Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 10/44] Input: pwm-vibra - prevent unbalanced regulator Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 11/44] Input: pwm-vibra - stop regulator after disabling pwm, not before Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 12/44] ARM: dts: Configure clock parent for pwm vibra Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 13/44] ARM: OMAP2+: Variable "reg" in function omap4_dsi_mux_pads() could be uninitialized Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 14/44] ASoC: dapm: fix out-of-bounds accesses to DAPM lookup tables Sasha Levin
2019-03-11 19:56 ` Sasha Levin [this message]
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 16/44] KVM: arm/arm64: Reset the VCPU without preemption and vcpu state loaded Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 17/44] arm/arm64: KVM: Allow a VCPU to fully reset itself Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 18/44] arm/arm64: KVM: Don't panic on failure to properly reset system registers Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 19/44] KVM: arm/arm64: vgic: Always initialize the group of private IRQs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 20/44] KVM: arm64: Forbid kprobing of the VHE world-switch code Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 21/44] ASoC: samsung: Prevent clk_get_rate() calls in atomic context Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 22/44] ARM: OMAP2+: fix lack of timer interrupts on CPU1 after hotplug Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 23/44] Input: cap11xx - switch to using set_brightness_blocking() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 24/44] Input: ps2-gpio - flush TX work when closing port Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 25/44] Input: matrix_keypad - use flush_delayed_work() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 26/44] mac80211: call drv_ibss_join() on restart Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 27/44] mac80211: Fix Tx aggregation session tear down with ITXQs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 28/44] netfilter: compat: initialize all fields in xt_init Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 29/44] blk-mq: insert rq with DONTPREP to hctx dispatch list when requeue Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 30/44] ipvs: fix dependency on nf_defrag_ipv6 Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 31/44] floppy: check_events callback should not return a negative number Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 32/44] xprtrdma: Make sure Send CQ is allocated on an existing compvec Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 33/44] NFS: Don't use page_file_mapping after removing the page Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 34/44] mm/gup: fix gup_pmd_range() for dax Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 35/44] Revert "mm: use early_pfn_to_nid in page_ext_init" Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 36/44] scsi: qla2xxx: Fix panic from use after free in qla2x00_async_tm_cmd Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 37/44] net: dsa: bcm_sf2: potential array overflow in bcm_sf2_sw_suspend() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 38/44] x86/CPU: Add Icelake model number Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 39/44] mm: page_alloc: fix ref bias in page_frag_alloc() for 1-byte allocs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 40/44] net: hns: Fix object reference leaks in hns_dsaf_roce_reset() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 41/44] i2c: cadence: Fix the hold bit setting Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 42/44] i2c: bcm2835: Clear current buffer pointers and counts after a transfer Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 43/44] auxdisplay: ht16k33: fix potential user-after-free on module unload Sasha Levin
2019-03-11 19:57 ` [PATCH AUTOSEL 4.19 44/44] Input: st-keyscan - fix potential zalloc NULL dereference Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311195700.138462-15-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®