mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	"H . Nikolaus Schaller" <hns@goldelico.com>,
	Keerthy <j-keerthy@ti.com>, Ladislav Michl <ladis@linux-mips.org>,
	Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
	Tero Kristo <t-kristo@ti.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.19 06/44] clocksource: timer-ti-dm: Fix pwm dmtimer usage of fck reparenting
Date: Mon, 11 Mar 2019 15:56:22 -0400	[thread overview]
Message-ID: <20190311195700.138462-6-sashal@kernel.org> (raw)
In-Reply-To: <20190311195700.138462-1-sashal@kernel.org>

From: Tony Lindgren <tony@atomide.com>

[ Upstream commit 983a5a43ec254cd5ddf3254db80ca96e8f8bb2a4 ]

Commit 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe
them with ti-sysc") moved some omap4 timers to probe with ti-sysc
interconnect target module. Turns out this broke pwm-omap-dmtimer
where we now try to reparent the clock to itself with the following:

omap_dm_timer_of_set_source: failed to set parent

With ti-sysc, we can now configure the clock sources in the dts
with assigned-clocks and assigned-clock-parents. So we should be able
to remove omap_dm_timer_of_set_source with clean-up patches later on.
But for now, let's just fix it first by checking if parent and fck
are the same and bail out of so.

Fixes: 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe them with ti-sysc")
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: H. Nikolaus Schaller <hns@goldelico.com>
Cc: Keerthy <j-keerthy@ti.com>
Cc: Ladislav Michl <ladis@linux-mips.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Tested-By: Andreas Kemnade <andreas@kemnade.info>
Tested-By: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/clocksource/timer-ti-dm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index 4cce6b224b87..3ecf84706640 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -154,6 +154,10 @@ static int omap_dm_timer_of_set_source(struct omap_dm_timer *timer)
 	if (IS_ERR(parent))
 		return -ENODEV;
 
+	/* Bail out if both clocks point to fck */
+	if (clk_is_match(parent, timer->fclk))
+		return 0;
+
 	ret = clk_set_parent(timer->fclk, parent);
 	if (ret < 0)
 		pr_err("%s: failed to set parent\n", __func__);
-- 
2.19.1


  parent reply	other threads:[~2019-03-11 20:08 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 19:56 [PATCH AUTOSEL 4.19 01/44] drm/imx: ignore plane updates on disabled crtcs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 02/44] gpu: ipu-v3: Fix i.MX51 CSI control registers offset Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 03/44] drm/imx: imx-ldb: add missing of_node_puts Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 04/44] gpu: ipu-v3: Fix CSI offsets for imx53 Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 05/44] ASoC: rt5682: Correct the setting while select ASRC clk for AD/DA filter Sasha Levin
2019-03-11 19:56 ` Sasha Levin [this message]
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 07/44] KVM: arm/arm64: vgic: Make vgic_dist->lpi_list_lock a raw_spinlock Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 08/44] arm64: dts: rockchip: fix graph_port warning on rk3399 bob kevin and excavator Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 09/44] s390/dasd: fix using offset into zero size array error Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 10/44] Input: pwm-vibra - prevent unbalanced regulator Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 11/44] Input: pwm-vibra - stop regulator after disabling pwm, not before Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 12/44] ARM: dts: Configure clock parent for pwm vibra Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 13/44] ARM: OMAP2+: Variable "reg" in function omap4_dsi_mux_pads() could be uninitialized Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 14/44] ASoC: dapm: fix out-of-bounds accesses to DAPM lookup tables Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 15/44] ASoC: rsnd: fixup rsnd_ssi_master_clk_start() user count check Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 16/44] KVM: arm/arm64: Reset the VCPU without preemption and vcpu state loaded Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 17/44] arm/arm64: KVM: Allow a VCPU to fully reset itself Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 18/44] arm/arm64: KVM: Don't panic on failure to properly reset system registers Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 19/44] KVM: arm/arm64: vgic: Always initialize the group of private IRQs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 20/44] KVM: arm64: Forbid kprobing of the VHE world-switch code Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 21/44] ASoC: samsung: Prevent clk_get_rate() calls in atomic context Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 22/44] ARM: OMAP2+: fix lack of timer interrupts on CPU1 after hotplug Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 23/44] Input: cap11xx - switch to using set_brightness_blocking() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 24/44] Input: ps2-gpio - flush TX work when closing port Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 25/44] Input: matrix_keypad - use flush_delayed_work() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 26/44] mac80211: call drv_ibss_join() on restart Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 27/44] mac80211: Fix Tx aggregation session tear down with ITXQs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 28/44] netfilter: compat: initialize all fields in xt_init Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 29/44] blk-mq: insert rq with DONTPREP to hctx dispatch list when requeue Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 30/44] ipvs: fix dependency on nf_defrag_ipv6 Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 31/44] floppy: check_events callback should not return a negative number Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 32/44] xprtrdma: Make sure Send CQ is allocated on an existing compvec Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 33/44] NFS: Don't use page_file_mapping after removing the page Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 34/44] mm/gup: fix gup_pmd_range() for dax Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 35/44] Revert "mm: use early_pfn_to_nid in page_ext_init" Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 36/44] scsi: qla2xxx: Fix panic from use after free in qla2x00_async_tm_cmd Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 37/44] net: dsa: bcm_sf2: potential array overflow in bcm_sf2_sw_suspend() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 38/44] x86/CPU: Add Icelake model number Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 39/44] mm: page_alloc: fix ref bias in page_frag_alloc() for 1-byte allocs Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 40/44] net: hns: Fix object reference leaks in hns_dsaf_roce_reset() Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 41/44] i2c: cadence: Fix the hold bit setting Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 42/44] i2c: bcm2835: Clear current buffer pointers and counts after a transfer Sasha Levin
2019-03-11 19:56 ` [PATCH AUTOSEL 4.19 43/44] auxdisplay: ht16k33: fix potential user-after-free on module unload Sasha Levin
2019-03-11 19:57 ` [PATCH AUTOSEL 4.19 44/44] Input: st-keyscan - fix potential zalloc NULL dereference Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311195700.138462-6-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=hns@goldelico.com \
    --cc=j-keerthy@ti.com \
    --cc=ladis@linux-mips.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®